hackedteam/core-blackberry

View on GitHub
bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java

Summary

Maintainability
F
4 days
Test Coverage

File ProgramClass.java has 430 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * ProGuard -- shrinking, optimization, obfuscation, and preverification
 *             of Java bytecode.
 *
 * Copyright (c) 2002-2011 Eric Lafortune (eric@graphics.cornell.edu)
Severity: Minor
Found in bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java - About 6 hrs to fix

    ProgramClass has 41 methods (exceeds 20 allowed). Consider refactoring.
    Open

    public class ProgramClass implements Clazz
    {
        public int             u4magic;
        public int             u4version;
        public int             u2constantPoolCount;
    Severity: Minor
    Found in bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java - About 5 hrs to fix

      Method hierarchyAccept has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
      Open

          public void hierarchyAccept(boolean      visitThisClass,
                                      boolean      visitSuperClass,
                                      boolean      visitInterfaces,
                                      boolean      visitSubclasses,
                                      ClassVisitor classVisitor)
      Severity: Minor
      Found in bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method hierarchyAccept has 58 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public void hierarchyAccept(boolean      visitThisClass,
                                      boolean      visitSuperClass,
                                      boolean      visitInterfaces,
                                      boolean      visitSubclasses,
                                      ClassVisitor classVisitor)
      Severity: Major
      Found in bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java - About 2 hrs to fix

        Method extendsOrImplements has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public boolean extendsOrImplements(String className)
            {
                if (getName().equals(className))
                {
                    return true;
        Severity: Minor
        Found in bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method extendsOrImplements has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public boolean extendsOrImplements(Clazz clazz)
            {
                if (this.equals(clazz))
                {
                    return true;
        Severity: Minor
        Found in bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method hierarchyAccept has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public void hierarchyAccept(boolean      visitThisClass,
                                        boolean      visitSuperClass,
                                        boolean      visitInterfaces,
                                        boolean      visitSubclasses,
                                        ClassVisitor classVisitor)
        Severity: Minor
        Found in bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java - About 35 mins to fix

          Method findMethod has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public Method findMethod(String name, String descriptor)
              {
                  for (int index = 0; index < u2methodsCount; index++)
                  {
                      Method method = methods[index];
          Severity: Minor
          Found in bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method findField has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public Field findField(String name, String descriptor)
              {
                  for (int index = 0; index < u2fieldsCount; index++)
                  {
                      Field field = fields[index];
          Severity: Minor
          Found in bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public Method findMethod(String name, String descriptor)
              {
                  for (int index = 0; index < u2methodsCount; index++)
                  {
                      Method method = methods[index];
          bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java on lines 312..325

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 91.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public Field findField(String name, String descriptor)
              {
                  for (int index = 0; index < u2fieldsCount; index++)
                  {
                      Field field = fields[index];
          bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java on lines 328..341

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 91.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              public void addSubClass(Clazz clazz)
              {
                  if (subClasses == null)
                  {
                      subClasses = new Clazz[1];
          bb-tools/proguard4.7/src/proguard/classfile/LibraryClass.java on lines 151..166

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 90.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              public boolean mayHaveImplementations(Method method)
              {
                  return
                      (u2accessFlags & ClassConstants.INTERNAL_ACC_FINAL) == 0 &&
                      (method == null ||
          bb-tools/proguard4.7/src/proguard/classfile/LibraryClass.java on lines 505..514

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 80.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 6 locations. Consider refactoring.
          Open

              public String getClassName(int constantIndex)
              {
                  try
                  {
                      return ((ClassConstant)constantPool[constantIndex]).getName(this);
          Severity: Major
          Found in bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java and 5 other locations - About 50 mins to fix
          bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java on lines 124..134
          bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java on lines 148..158
          bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java on lines 160..170
          bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java on lines 173..183
          bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java on lines 185..195

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 58.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 6 locations. Consider refactoring.
          Open

              public String getStringString(int constantIndex)
              {
                  try
                  {
                      return ((StringConstant)constantPool[constantIndex]).getString(this);
          Severity: Major
          Found in bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java and 5 other locations - About 50 mins to fix
          bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java on lines 136..146
          bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java on lines 148..158
          bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java on lines 160..170
          bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java on lines 173..183
          bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java on lines 185..195

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 58.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 6 locations. Consider refactoring.
          Open

              public String getRefName(int constantIndex)
              {
                  try
                  {
                      return ((RefConstant)constantPool[constantIndex]).getName(this);
          Severity: Major
          Found in bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java and 5 other locations - About 50 mins to fix
          bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java on lines 124..134
          bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java on lines 136..146
          bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java on lines 148..158
          bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java on lines 160..170
          bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java on lines 185..195

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 58.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 6 locations. Consider refactoring.
          Open

              public String getType(int constantIndex)
              {
                  try
                  {
                      return ((NameAndTypeConstant)constantPool[constantIndex]).getType(this);
          Severity: Major
          Found in bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java and 5 other locations - About 50 mins to fix
          bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java on lines 124..134
          bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java on lines 136..146
          bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java on lines 148..158
          bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java on lines 173..183
          bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java on lines 185..195

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 58.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 6 locations. Consider refactoring.
          Open

              public String getName(int constantIndex)
              {
                  try
                  {
                      return ((NameAndTypeConstant)constantPool[constantIndex]).getName(this);
          Severity: Major
          Found in bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java and 5 other locations - About 50 mins to fix
          bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java on lines 124..134
          bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java on lines 136..146
          bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java on lines 160..170
          bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java on lines 173..183
          bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java on lines 185..195

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 58.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 6 locations. Consider refactoring.
          Open

              public String getRefType(int constantIndex)
              {
                  try
                  {
                      return ((RefConstant)constantPool[constantIndex]).getType(this);
          Severity: Major
          Found in bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java and 5 other locations - About 50 mins to fix
          bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java on lines 124..134
          bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java on lines 136..146
          bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java on lines 148..158
          bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java on lines 160..170
          bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java on lines 173..183

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 58.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  for (int index = 0; index < u2interfacesCount; index++)
                  {
                      Clazz interfaceClass = getInterface(index);
                      if (interfaceClass != null &&
                          interfaceClass.extendsOrImplements(className))
          Severity: Minor
          Found in bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java and 1 other location - About 40 mins to fix
          bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java on lines 270..278

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  for (int index = 0; index < u2interfacesCount; index++)
                  {
                      Clazz interfaceClass = getInterface(index);
                      if (interfaceClass != null &&
                          interfaceClass.extendsOrImplements(clazz))
          Severity: Minor
          Found in bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java and 1 other location - About 40 mins to fix
          bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java on lines 298..306

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              public void subclassesAccept(ClassVisitor classVisitor)
              {
                  if (subClasses != null)
                  {
                      for (int index = 0; index < subClasses.length; index++)
          Severity: Minor
          Found in bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java and 1 other location - About 40 mins to fix
          bb-tools/proguard4.7/src/proguard/classfile/LibraryClass.java on lines 417..426

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status