Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/StackSizeComputer.java

Summary

Maintainability
C
1 day
Test Coverage

Method evaluateInstructionBlock has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    private void evaluateInstructionBlock(Clazz         clazz,
                                          Method        method,
                                          CodeAttribute codeAttribute,
                                          int           instructionOffset)
    {
Severity: Minor
Found in bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/StackSizeComputer.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method evaluateInstructionBlock has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private void evaluateInstructionBlock(Clazz         clazz,
                                          Method        method,
                                          CodeAttribute codeAttribute,
                                          int           instructionOffset)
    {
Severity: Major
Found in bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/StackSizeComputer.java - About 2 hrs to fix

    Method visitConstantInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public void visitConstantInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, ConstantInstruction constantInstruction)
    Severity: Minor
    Found in bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/StackSizeComputer.java - About 35 mins to fix

      Method visitVariableInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public void visitVariableInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, VariableInstruction variableInstruction)
      Severity: Minor
      Found in bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/StackSizeComputer.java - About 35 mins to fix

        Method visitSimpleInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public void visitSimpleInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, SimpleInstruction simpleInstruction)
        Severity: Minor
        Found in bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/StackSizeComputer.java - About 35 mins to fix

          Method visitBranchInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public void visitBranchInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, BranchInstruction branchInstruction)
          Severity: Minor
          Found in bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/StackSizeComputer.java - About 35 mins to fix

            Method visitAnySwitchInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public void visitAnySwitchInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, SwitchInstruction switchInstruction)
            Severity: Minor
            Found in bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/StackSizeComputer.java - About 35 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public void visitCodeAttribute(Clazz clazz, Method method, CodeAttribute codeAttribute)
    {
//        DEBUG =
//            clazz.getName().equals("abc/Def") &&
//            method.getName(clazz).equals("abc");
              Severity: Major
              Found in bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/StackSizeComputer.java and 1 other location - About 2 hrs to fix
              bb-tools/proguard4.7/src/proguard/preverify/CodeSubroutineInliner.java on lines 65..93

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 136.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                      if (DEBUG)
        {
            System.out.println("StackSizeComputer: "+clazz.getName()+"."+method.getName(clazz)+method.getDescriptor(clazz));
        }
              Severity: Minor
              Found in bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/StackSizeComputer.java and 2 other locations - About 30 mins to fix
              bb-tools/proguard4.7/src/proguard/classfile/editor/CodeAttributeEditor.java on lines 327..330
              bb-tools/proguard4.7/src/proguard/optimize/peephole/UnreachableCodeRemover.java on lines 106..109

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 42.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      for (int index = 0; index < jumpOffsets.length; index++)
        {
            // Evaluate the jump instruction block.
            evaluateInstructionBlock(clazz,
                                     method,
              Severity: Minor
              Found in bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/StackSizeComputer.java and 1 other location - About 30 mins to fix
              bb-tools/proguard4.7/src/proguard/optimize/peephole/ReachableCodeMarker.java on lines 204..207

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 42.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status