Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star
bb-tools/proguard4.7/src/proguard/classfile/editor/ConstantPoolShrinker.java

Summary

Maintainability
D
2 days
Test Coverage

ConstantPoolShrinker has 50 methods (exceeds 20 allowed). Consider refactoring.
Open

public class ConstantPoolShrinker
extends      SimplifiedVisitor
implements   ClassVisitor,
             MemberVisitor,
             ConstantVisitor,
Severity: Minor
Found in bb-tools/proguard4.7/src/proguard/classfile/editor/ConstantPoolShrinker.java - About 7 hrs to fix

    File ConstantPoolShrinker.java has 326 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
 * ProGuard -- shrinking, optimization, obfuscation, and preverification
 *             of Java bytecode.
 *
 * Copyright (c) 2002-2011 Eric Lafortune (eric@graphics.cornell.edu)
    Severity: Minor
    Found in bb-tools/proguard4.7/src/proguard/classfile/editor/ConstantPoolShrinker.java - About 3 hrs to fix

      Method visitMoreZeroFrame has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public void visitMoreZeroFrame(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, MoreZeroFrame moreZeroFrame)
      Severity: Minor
      Found in bb-tools/proguard4.7/src/proguard/classfile/editor/ConstantPoolShrinker.java - About 35 mins to fix

        Method visitSameOneFrame has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public void visitSameOneFrame(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, SameOneFrame sameOneFrame)
        Severity: Minor
        Found in bb-tools/proguard4.7/src/proguard/classfile/editor/ConstantPoolShrinker.java - About 35 mins to fix

          Method visitObjectType has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public void visitObjectType(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, ObjectType objectType)
          Severity: Minor
          Found in bb-tools/proguard4.7/src/proguard/classfile/editor/ConstantPoolShrinker.java - About 35 mins to fix

            Method visitAnyInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public void visitAnyInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, Instruction instruction) {}
            Severity: Minor
            Found in bb-tools/proguard4.7/src/proguard/classfile/editor/ConstantPoolShrinker.java - About 35 mins to fix

              Method visitFullFrame has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public void visitFullFrame(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, FullFrame fullFrame)
              Severity: Minor
              Found in bb-tools/proguard4.7/src/proguard/classfile/editor/ConstantPoolShrinker.java - About 35 mins to fix

                Method visitAnyVerificationType has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public void visitAnyVerificationType(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, VerificationType verificationType) {}
                Severity: Minor
                Found in bb-tools/proguard4.7/src/proguard/classfile/editor/ConstantPoolShrinker.java - About 35 mins to fix

                  Method visitConstantInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      public void visitConstantInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, ConstantInstruction constantInstruction)
                  Severity: Minor
                  Found in bb-tools/proguard4.7/src/proguard/classfile/editor/ConstantPoolShrinker.java - About 35 mins to fix

                    Method visitAnyStackMapFrame has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public void visitAnyStackMapFrame(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, StackMapFrame stackMapFrame) {}
                    Severity: Minor
                    Found in bb-tools/proguard4.7/src/proguard/classfile/editor/ConstantPoolShrinker.java - About 35 mins to fix

                      Method shrinkConstantPool has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                          private int shrinkConstantPool(Constant[] constantPool, int length)
    {
        // Create a new index map, if necessary.
        if (constantIndexMap.length < length)
        {
                      Severity: Minor
                      Found in bb-tools/proguard4.7/src/proguard/classfile/editor/ConstantPoolShrinker.java - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          public void visitEnumConstantElementValue(Clazz clazz, Annotation annotation, EnumConstantElementValue enumConstantElementValue)
    {
        if (enumConstantElementValue.u2elementNameIndex != 0)
        {
            markConstant(clazz, enumConstantElementValue.u2elementNameIndex);
                      Severity: Minor
                      Found in bb-tools/proguard4.7/src/proguard/classfile/editor/ConstantPoolShrinker.java and 1 other location - About 40 mins to fix
                      bb-tools/proguard4.7/src/proguard/classfile/editor/Utf8Shrinker.java on lines 336..345

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 48.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Identical blocks of code found in 3 locations. Consider refactoring.
                      Open

                          public void visitFullFrame(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, FullFrame fullFrame)
    {
        // Mark the constant pool entries referenced by the verification types.
        fullFrame.variablesAccept(clazz, method, codeAttribute, offset, this);
        fullFrame.stackAccept(clazz, method, codeAttribute, offset, this);
                      Severity: Minor
                      Found in bb-tools/proguard4.7/src/proguard/classfile/editor/ConstantPoolShrinker.java and 2 other locations - About 30 mins to fix
                      bb-tools/proguard4.7/src/proguard/classfile/editor/ConstantPoolRemapper.java on lines 535..540
                      bb-tools/proguard4.7/src/proguard/shrink/UsageMarker.java on lines 833..838

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 40.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          public void visitArrayElementValue(Clazz clazz, Annotation annotation, ArrayElementValue arrayElementValue)
    {
        if (arrayElementValue.u2elementNameIndex != 0)
        {
            markConstant(clazz, arrayElementValue.u2elementNameIndex);
                      Severity: Minor
                      Found in bb-tools/proguard4.7/src/proguard/classfile/editor/ConstantPoolShrinker.java and 1 other location - About 30 mins to fix
                      bb-tools/proguard4.7/src/proguard/classfile/editor/Utf8Shrinker.java on lines 371..380

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 40.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status