Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star
bb-tools/proguard4.7/src/proguard/classfile/instruction/ConstantInstruction.java

Summary

Maintainability
B
4 hrs
Test Coverage

ConstantInstruction has 27 methods (exceeds 20 allowed). Consider refactoring.
Open

public class ConstantInstruction extends Instruction
implements   ConstantVisitor
{
    public int constantIndex;
    public int constant;
Severity: Minor
Found in bb-tools/proguard4.7/src/proguard/classfile/instruction/ConstantInstruction.java - About 3 hrs to fix

    Method accept has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public void accept(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, InstructionVisitor instructionVisitor)
    Severity: Minor
    Found in bb-tools/proguard4.7/src/proguard/classfile/instruction/ConstantInstruction.java - About 35 mins to fix

      Method shrink has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public Instruction shrink()
    {
        // Do we need a short index or a long index?
        if (requiredConstantIndexSize() == 1)
        {
      Severity: Minor
      Found in bb-tools/proguard4.7/src/proguard/classfile/instruction/ConstantInstruction.java - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public ConstantInstruction copy(ConstantInstruction constantInstruction)
    {
        this.opcode        = constantInstruction.opcode;
        this.constantIndex = constantInstruction.constantIndex;
        this.constant      = constantInstruction.constant;
      Severity: Minor
      Found in bb-tools/proguard4.7/src/proguard/classfile/instruction/ConstantInstruction.java and 1 other location - About 35 mins to fix
      bb-tools/proguard4.7/src/proguard/classfile/instruction/SwitchInstruction.java on lines 59..66

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 44.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status