Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star
bb-tools/proguard4.7/src/proguard/classfile/util/ClassReferenceInitializer.java

Summary

Maintainability
D
2 days
Test Coverage

ClassReferenceInitializer has 33 methods (exceeds 20 allowed). Consider refactoring.
Open

public class ClassReferenceInitializer
extends      SimplifiedVisitor
implements   ClassVisitor,
             MemberVisitor,
             ConstantVisitor,
Severity: Minor
Found in bb-tools/proguard4.7/src/proguard/classfile/util/ClassReferenceInitializer.java - About 4 hrs to fix

    File ClassReferenceInitializer.java has 329 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
 * ProGuard -- shrinking, optimization, obfuscation, and preverification
 *             of Java bytecode.
 *
 * Copyright (c) 2002-2011 Eric Lafortune (eric@graphics.cornell.edu)
    Severity: Minor
    Found in bb-tools/proguard4.7/src/proguard/classfile/util/ClassReferenceInitializer.java - About 3 hrs to fix

      Method findClass has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private Clazz findClass(String referencingClassName, String name)
    {
        // Is it an array type?
        if (ClassUtil.isInternalArrayType(name))
        {
      Severity: Minor
      Found in bb-tools/proguard4.7/src/proguard/classfile/util/ClassReferenceInitializer.java - About 1 hr to fix

        Method visitAnyRefConstant has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public void visitAnyRefConstant(Clazz clazz, RefConstant refConstant)
    {
        String className = refConstant.getClassName(clazz);

        // Methods for array types should be found in the Object class.
        Severity: Minor
        Found in bb-tools/proguard4.7/src/proguard/classfile/util/ClassReferenceInitializer.java - About 1 hr to fix

          Method findClass has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              private Clazz findClass(String referencingClassName, String name)
    {
        // Is it an array type?
        if (ClassUtil.isInternalArrayType(name))
        {
          Severity: Minor
          Found in bb-tools/proguard4.7/src/proguard/classfile/util/ClassReferenceInitializer.java - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method findReferencedClasses has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              private Clazz[] findReferencedClasses(String referencingClassName,
                                          String descriptor)
    {
        DescriptorClassEnumeration enumeration =
            new DescriptorClassEnumeration(descriptor);
          Severity: Minor
          Found in bb-tools/proguard4.7/src/proguard/classfile/util/ClassReferenceInitializer.java - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method visitEnclosingMethodAttribute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public void visitEnclosingMethodAttribute(Clazz clazz, EnclosingMethodAttribute enclosingMethodAttribute)
    {
        String className          = clazz.getName();
        String enclosingClassName = enclosingMethodAttribute.getClassName(clazz);
          Severity: Minor
          Found in bb-tools/proguard4.7/src/proguard/classfile/util/ClassReferenceInitializer.java - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              private Clazz findClass(String referencingClassName, String name)
    {
        // Is it an array type?
        if (ClassUtil.isInternalArrayType(name))
        {
          Severity: Major
          Found in bb-tools/proguard4.7/src/proguard/classfile/util/ClassReferenceInitializer.java and 1 other location - About 2 hrs to fix
          bb-tools/proguard4.7/src/proguard/classfile/util/DynamicClassReferenceInitializer.java on lines 436..484

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 173.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 16 locations. Consider refactoring.
          Open

              public ClassReferenceInitializer(ClassPool      programClassPool,
                                     ClassPool      libraryClassPool,
                                     WarningPrinter missingClassWarningPrinter,
                                     WarningPrinter missingMemberWarningPrinter,
                                     WarningPrinter dependencyWarningPrinter)
          Severity: Major
          Found in bb-tools/proguard4.7/src/proguard/classfile/util/ClassReferenceInitializer.java and 15 other locations - About 50 mins to fix
          bb-tools/proguard4.7/src/proguard/KeepClassSpecification.java on lines 50..61
          bb-tools/proguard4.7/src/proguard/MemberSpecification.java on lines 71..82
          bb-tools/proguard4.7/src/proguard/classfile/ProgramMember.java on lines 58..69
          bb-tools/proguard4.7/src/proguard/classfile/attribute/LocalVariableInfo.java on lines 59..70
          bb-tools/proguard4.7/src/proguard/classfile/attribute/LocalVariableTypeInfo.java on lines 60..71
          bb-tools/proguard4.7/src/proguard/classfile/attribute/preverification/FullFrame.java on lines 66..77
          bb-tools/proguard4.7/src/proguard/classfile/instruction/TableSwitchInstruction.java on lines 48..59
          bb-tools/proguard4.7/src/proguard/classfile/util/DynamicMemberReferenceInitializer.java on lines 520..531
          bb-tools/proguard4.7/src/proguard/classfile/visitor/ClassHierarchyTraveler.java on lines 56..68
          bb-tools/proguard4.7/src/proguard/classfile/visitor/MethodImplementationTraveler.java on lines 57..68
          bb-tools/proguard4.7/src/proguard/gui/splash/ImageSprite.java on lines 47..58
          bb-tools/proguard4.7/src/proguard/gui/splash/ShadowedSprite.java on lines 51..62
          bb-tools/proguard4.7/src/proguard/io/ClassReader.java on lines 55..66
          bb-tools/proguard4.7/src/proguard/retrace/ReTrace.java on lines 659..666
          bb-tools/proguard4.7/src/proguard/util/VariableStringMatcher.java on lines 38..49

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 60.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status