Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star
bb-tools/proguard4.7/src/proguard/classfile/util/ClassUtil.java

Summary

Maintainability
F
1 wk
Test Coverage

Method externalType has a Cognitive Complexity of 69 (exceeds 5 allowed). Consider refactoring.
Open

    public static String externalType(String internalType)
    {
        // Strip the array part, if any.
        int dimensionCount = internalArrayTypeDimensionCount(internalType);
        if (dimensionCount > 0)
Severity: Minor
Found in bb-tools/proguard4.7/src/proguard/classfile/util/ClassUtil.java - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File ClassUtil.java has 619 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * ProGuard -- shrinking, optimization, obfuscation, and preverification
 *             of Java bytecode.
 *
 * Copyright (c) 2002-2011 Eric Lafortune (eric@graphics.cornell.edu)
Severity: Major
Found in bb-tools/proguard4.7/src/proguard/classfile/util/ClassUtil.java - About 1 day to fix

    Method internalType has a Cognitive Complexity of 58 (exceeds 5 allowed). Consider refactoring.
    Open

        public static String internalType(String externalType)
    {
        // Strip the array part, if any.
        int dimensionCount = externalArrayTypeDimensionCount(externalType);
        if (dimensionCount > 0)
    Severity: Minor
    Found in bb-tools/proguard4.7/src/proguard/classfile/util/ClassUtil.java - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    ClassUtil has 53 methods (exceeds 20 allowed). Consider refactoring.
    Open

    public class ClassUtil
{
    private static final String EMPTY_STRING = "";
    Severity: Major
    Found in bb-tools/proguard4.7/src/proguard/classfile/util/ClassUtil.java - About 7 hrs to fix

      Method internalClassVersion has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
      Open

          public static int internalClassVersion(String classVersion)
    {
        return
            classVersion.equals(ClassConstants.EXTERNAL_CLASS_VERSION_1_0) ||
            classVersion.equals(ClassConstants.EXTERNAL_CLASS_VERSION_1_1) ? ClassConstants.INTERNAL_CLASS_VERSION_1_0 :
      Severity: Minor
      Found in bb-tools/proguard4.7/src/proguard/classfile/util/ClassUtil.java - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method externalMethodAccessFlags has 54 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static String externalMethodAccessFlags(int accessFlags, String prefix)
    {
        if (accessFlags == 0)
        {
            return EMPTY_STRING;
      Severity: Major
      Found in bb-tools/proguard4.7/src/proguard/classfile/util/ClassUtil.java - About 2 hrs to fix

        Method externalClassAccessFlags has 46 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static String externalClassAccessFlags(int accessFlags, String prefix)
    {
        if (accessFlags == 0)
        {
            return EMPTY_STRING;
        Severity: Minor
        Found in bb-tools/proguard4.7/src/proguard/classfile/util/ClassUtil.java - About 1 hr to fix

          Method externalMethodAccessFlags has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

              public static String externalMethodAccessFlags(int accessFlags, String prefix)
    {
        if (accessFlags == 0)
        {
            return EMPTY_STRING;
          Severity: Minor
          Found in bb-tools/proguard4.7/src/proguard/classfile/util/ClassUtil.java - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method externalType has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public static String externalType(String internalType)
    {
        // Strip the array part, if any.
        int dimensionCount = internalArrayTypeDimensionCount(internalType);
        if (dimensionCount > 0)
          Severity: Minor
          Found in bb-tools/proguard4.7/src/proguard/classfile/util/ClassUtil.java - About 1 hr to fix

            Method externalFieldAccessFlags has 38 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public static String externalFieldAccessFlags(int accessFlags, String prefix)
    {
        if (accessFlags == 0)
        {
            return EMPTY_STRING;
            Severity: Minor
            Found in bb-tools/proguard4.7/src/proguard/classfile/util/ClassUtil.java - About 1 hr to fix

              Method internalType has 37 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public static String internalType(String externalType)
    {
        // Strip the array part, if any.
        int dimensionCount = externalArrayTypeDimensionCount(externalType);
        if (dimensionCount > 0)
              Severity: Minor
              Found in bb-tools/proguard4.7/src/proguard/classfile/util/ClassUtil.java - About 1 hr to fix

                Method externalClassAccessFlags has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                    public static String externalClassAccessFlags(int accessFlags, String prefix)
    {
        if (accessFlags == 0)
        {
            return EMPTY_STRING;
                Severity: Minor
                Found in bb-tools/proguard4.7/src/proguard/classfile/util/ClassUtil.java - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method externalFieldAccessFlags has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    public static String externalFieldAccessFlags(int accessFlags, String prefix)
    {
        if (accessFlags == 0)
        {
            return EMPTY_STRING;
                Severity: Minor
                Found in bb-tools/proguard4.7/src/proguard/classfile/util/ClassUtil.java - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public static String internalPackageName(String internalClassName)
    {
        String internalPackagePrefix = internalPackagePrefix(internalClassName);
        int length = internalPackagePrefix.length();
        return length > 0 ?
                Severity: Minor
                Found in bb-tools/proguard4.7/src/proguard/classfile/util/ClassUtil.java and 1 other location - About 40 mins to fix
                bb-tools/proguard4.7/src/proguard/classfile/util/ClassUtil.java on lines 1205..1212

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 48.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public static String externalPackageName(String externalClassName)
    {
        String externalPackagePrefix = externalPackagePrefix(externalClassName);
        int length = externalPackagePrefix.length();
        return length > 0 ?
                Severity: Minor
                Found in bb-tools/proguard4.7/src/proguard/classfile/util/ClassUtil.java and 1 other location - About 40 mins to fix
                bb-tools/proguard4.7/src/proguard/classfile/util/ClassUtil.java on lines 1174..1181

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 48.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status