Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star
bb-tools/proguard4.7/src/proguard/classfile/util/DynamicClassReferenceInitializer.java

Summary

Maintainability
C
1 day
Test Coverage

File DynamicClassReferenceInitializer.java has 280 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * ProGuard -- shrinking, optimization, obfuscation, and preverification
 *             of Java bytecode.
 *
 * Copyright (c) 2002-2011 Eric Lafortune (eric@graphics.cornell.edu)
Severity: Minor
Found in bb-tools/proguard4.7/src/proguard/classfile/util/DynamicClassReferenceInitializer.java - About 2 hrs to fix

    Method findClass has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private Clazz findClass(String referencingClassName, String name)
    {
        // Is it an array type?
        if (ClassUtil.isInternalArrayType(name))
        {
    Severity: Minor
    Found in bb-tools/proguard4.7/src/proguard/classfile/util/DynamicClassReferenceInitializer.java - About 1 hr to fix

      Method visitAnyInstruction has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public void visitAnyInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, Instruction instruction)
    {
        // Try to match the Class.forName("SomeClass") construct.
        instruction.accept(clazz, method, codeAttribute, offset,
                           constantClassForNameMatcher);
      Severity: Minor
      Found in bb-tools/proguard4.7/src/proguard/classfile/util/DynamicClassReferenceInitializer.java - About 1 hr to fix

        Method findClass has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            private Clazz findClass(String referencingClassName, String name)
    {
        // Is it an array type?
        if (ClassUtil.isInternalArrayType(name))
        {
        Severity: Minor
        Found in bb-tools/proguard4.7/src/proguard/classfile/util/DynamicClassReferenceInitializer.java - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method visitAnyInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public void visitAnyInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, Instruction instruction)
        Severity: Minor
        Found in bb-tools/proguard4.7/src/proguard/classfile/util/DynamicClassReferenceInitializer.java - About 35 mins to fix

          Method isDotClassMethodCode has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              private boolean isDotClassMethodCode(Clazz                      clazz,
                                         Method                     method,
                                         CodeAttribute              codeAttribute,
                                         InstructionSequenceMatcher codeMatcher,
                                         int                        codeLength)
          Severity: Minor
          Found in bb-tools/proguard4.7/src/proguard/classfile/util/DynamicClassReferenceInitializer.java - About 35 mins to fix

            Method visitMethodrefConstant has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                public void visitMethodrefConstant(Clazz clazz, MethodrefConstant methodrefConstant)
    {
        String methodType = methodrefConstant.getType(clazz);

        // Do the method's class and type match?
            Severity: Minor
            Found in bb-tools/proguard4.7/src/proguard/classfile/util/DynamicClassReferenceInitializer.java - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method visitAnyInstruction has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public void visitAnyInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, Instruction instruction)
    {
        // Try to match the Class.forName("SomeClass") construct.
        instruction.accept(clazz, method, codeAttribute, offset,
                           constantClassForNameMatcher);
            Severity: Minor
            Found in bb-tools/proguard4.7/src/proguard/classfile/util/DynamicClassReferenceInitializer.java - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                private Clazz findClass(String referencingClassName, String name)
    {
        // Is it an array type?
        if (ClassUtil.isInternalArrayType(name))
        {
            Severity: Major
            Found in bb-tools/proguard4.7/src/proguard/classfile/util/DynamicClassReferenceInitializer.java and 1 other location - About 2 hrs to fix
            bb-tools/proguard4.7/src/proguard/classfile/util/ClassReferenceInitializer.java on lines 510..558

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 173.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public DynamicClassReferenceInitializer(ClassPool      programClassPool,
                                            ClassPool      libraryClassPool,
                                            WarningPrinter missingNotePrinter,
                                            WarningPrinter dependencyWarningPrinter,
                                            WarningPrinter notePrinter,
            Severity: Major
            Found in bb-tools/proguard4.7/src/proguard/classfile/util/DynamicClassReferenceInitializer.java and 1 other location - About 1 hr to fix
            bb-tools/proguard4.7/src/proguard/classfile/visitor/SimilarMemberVisitor.java on lines 61..74

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 71.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status