Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star
bb-tools/proguard4.7/src/proguard/evaluation/BasicInvocationUnit.java

Summary

Maintainability
C
7 hrs
Test Coverage

File BasicInvocationUnit.java has 251 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * ProGuard -- shrinking, optimization, obfuscation, and preverification
 *             of Java bytecode.
 *
 * Copyright (c) 2002-2011 Eric Lafortune (eric@graphics.cornell.edu)
Severity: Minor
Found in bb-tools/proguard4.7/src/proguard/evaluation/BasicInvocationUnit.java - About 2 hrs to fix

    Method enterMethod has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public void enterMethod(Clazz clazz, Method method, Variables variables)
    {
        String descriptor = method.getDescriptor(clazz);

        // Initialize the parameters.
    Severity: Minor
    Found in bb-tools/proguard4.7/src/proguard/evaluation/BasicInvocationUnit.java - About 1 hr to fix

      Method invokeMember has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public void invokeMember(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, ConstantInstruction constantInstruction, Stack stack)
    {
        int constantIndex = constantInstruction.constantIndex;

        switch (constantInstruction.opcode)
      Severity: Minor
      Found in bb-tools/proguard4.7/src/proguard/evaluation/BasicInvocationUnit.java - About 1 hr to fix

        Method invokeMember has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public void invokeMember(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, ConstantInstruction constantInstruction, Stack stack)
        Severity: Minor
        Found in bb-tools/proguard4.7/src/proguard/evaluation/BasicInvocationUnit.java - About 45 mins to fix

          Method getMethodParameterValue has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              protected Value getMethodParameterValue(Clazz  clazz,
                                            Method method,
                                            int    parameterIndex,
                                            String type,
                                            Clazz  referencedClass)
          Severity: Minor
          Found in bb-tools/proguard4.7/src/proguard/evaluation/BasicInvocationUnit.java - About 35 mins to fix

            Method enterMethod has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                public void enterMethod(Clazz clazz, Method method, Variables variables)
    {
        String descriptor = method.getDescriptor(clazz);

        // Initialize the parameters.
            Severity: Minor
            Found in bb-tools/proguard4.7/src/proguard/evaluation/BasicInvocationUnit.java - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public void visitProgramMethod(ProgramClass programClass, ProgramMethod programMethod)
    {
        Clazz[] referencedClasses = programMethod.referencedClasses;
        if (referencedClasses != null)
        {
            Severity: Minor
            Found in bb-tools/proguard4.7/src/proguard/evaluation/BasicInvocationUnit.java and 1 other location - About 35 mins to fix
            bb-tools/proguard4.7/src/proguard/evaluation/BasicInvocationUnit.java on lines 412..419

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 43.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public void visitLibraryMethod(LibraryClass programClass, LibraryMethod programMethod)
    {
        Clazz[] referencedClasses = programMethod.referencedClasses;
        if (referencedClasses != null)
        {
            Severity: Minor
            Found in bb-tools/proguard4.7/src/proguard/evaluation/BasicInvocationUnit.java and 1 other location - About 35 mins to fix
            bb-tools/proguard4.7/src/proguard/evaluation/BasicInvocationUnit.java on lines 396..403

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 43.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status