Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star
bb-tools/proguard4.7/src/proguard/evaluation/Processor.java

Summary

Maintainability
F
5 days
Test Coverage

Method visitSimpleInstruction has 364 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public void visitSimpleInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, SimpleInstruction simpleInstruction)
    {
        switch (simpleInstruction.opcode)
        {
            case InstructionConstants.OP_NOP:
Severity: Major
Found in bb-tools/proguard4.7/src/proguard/evaluation/Processor.java - About 1 day to fix

    File Processor.java has 676 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
 * ProGuard -- shrinking, optimization, obfuscation, and preverification
 *             of Java bytecode.
 *
 * Copyright (c) 2002-2011 Eric Lafortune (eric@graphics.cornell.edu)
    Severity: Major
    Found in bb-tools/proguard4.7/src/proguard/evaluation/Processor.java - About 1 day to fix

      Method visitVariableInstruction has 88 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public void visitVariableInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, VariableInstruction variableInstruction)
    {
        int variableIndex = variableInstruction.variableIndex;

        switch (variableInstruction.opcode)
      Severity: Major
      Found in bb-tools/proguard4.7/src/proguard/evaluation/Processor.java - About 3 hrs to fix

        Method visitBranchInstruction has 80 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public void visitBranchInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, BranchInstruction branchInstruction)
    {
        int branchTarget = offset + branchInstruction.branchOffset;

        switch (branchInstruction.opcode)
        Severity: Major
        Found in bb-tools/proguard4.7/src/proguard/evaluation/Processor.java - About 3 hrs to fix

          Method visitConstantInstruction has 61 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public void visitConstantInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, ConstantInstruction constantInstruction)
    {
        int constantIndex = constantInstruction.constantIndex;

        switch (constantInstruction.opcode)
          Severity: Major
          Found in bb-tools/proguard4.7/src/proguard/evaluation/Processor.java - About 2 hrs to fix

            Method visitSimpleInstruction has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                public void visitSimpleInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, SimpleInstruction simpleInstruction)
    {
        switch (simpleInstruction.opcode)
        {
            case InstructionConstants.OP_NOP:
            Severity: Minor
            Found in bb-tools/proguard4.7/src/proguard/evaluation/Processor.java - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method visitConstantInstruction has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                public void visitConstantInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, ConstantInstruction constantInstruction)
    {
        int constantIndex = constantInstruction.constantIndex;

        switch (constantInstruction.opcode)
            Severity: Minor
            Found in bb-tools/proguard4.7/src/proguard/evaluation/Processor.java - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method visitLookUpSwitchInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public void visitLookUpSwitchInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, LookUpSwitchInstruction lookUpSwitchInstruction)
            Severity: Minor
            Found in bb-tools/proguard4.7/src/proguard/evaluation/Processor.java - About 35 mins to fix

              Method visitSimpleInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public void visitSimpleInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, SimpleInstruction simpleInstruction)
              Severity: Minor
              Found in bb-tools/proguard4.7/src/proguard/evaluation/Processor.java - About 35 mins to fix

                Method visitConstantInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public void visitConstantInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, ConstantInstruction constantInstruction)
                Severity: Minor
                Found in bb-tools/proguard4.7/src/proguard/evaluation/Processor.java - About 35 mins to fix

                  Method visitBranchInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      public void visitBranchInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, BranchInstruction branchInstruction)
                  Severity: Minor
                  Found in bb-tools/proguard4.7/src/proguard/evaluation/Processor.java - About 35 mins to fix

                    Method visitVariableInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public void visitVariableInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, VariableInstruction variableInstruction)
                    Severity: Minor
                    Found in bb-tools/proguard4.7/src/proguard/evaluation/Processor.java - About 35 mins to fix

                      Method visitTableSwitchInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          public void visitTableSwitchInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, TableSwitchInstruction tableSwitchInstruction)
                      Severity: Minor
                      Found in bb-tools/proguard4.7/src/proguard/evaluation/Processor.java - About 35 mins to fix

                        Similar blocks of code found in 4 locations. Consider refactoring.
                        Open

                                    case InstructionConstants.OP_LDIV:
                try
                {
                    stack.push(stack.lpop().divideOf(stack.lpop()));
                }
                        Severity: Major
                        Found in bb-tools/proguard4.7/src/proguard/evaluation/Processor.java and 3 other locations - About 30 mins to fix
                        bb-tools/proguard4.7/src/proguard/evaluation/Processor.java on lines 265..278
                        bb-tools/proguard4.7/src/proguard/evaluation/Processor.java on lines 303..316
                        bb-tools/proguard4.7/src/proguard/evaluation/Processor.java on lines 318..331

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 42.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 4 locations. Consider refactoring.
                        Open

                                    case InstructionConstants.OP_IREM:
                try
                {
                    stack.push(stack.ipop().remainderOf(stack.ipop()));
                }
                        Severity: Major
                        Found in bb-tools/proguard4.7/src/proguard/evaluation/Processor.java and 3 other locations - About 30 mins to fix
                        bb-tools/proguard4.7/src/proguard/evaluation/Processor.java on lines 265..278
                        bb-tools/proguard4.7/src/proguard/evaluation/Processor.java on lines 280..293
                        bb-tools/proguard4.7/src/proguard/evaluation/Processor.java on lines 318..331

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 42.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 4 locations. Consider refactoring.
                        Open

                                    case InstructionConstants.OP_LREM:
                try
                {
                    stack.push(stack.lpop().remainderOf(stack.lpop()));
                }
                        Severity: Major
                        Found in bb-tools/proguard4.7/src/proguard/evaluation/Processor.java and 3 other locations - About 30 mins to fix
                        bb-tools/proguard4.7/src/proguard/evaluation/Processor.java on lines 265..278
                        bb-tools/proguard4.7/src/proguard/evaluation/Processor.java on lines 280..293
                        bb-tools/proguard4.7/src/proguard/evaluation/Processor.java on lines 303..316

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 42.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 4 locations. Consider refactoring.
                        Open

                                    case InstructionConstants.OP_IDIV:
                try
                {
                    stack.push(stack.ipop().divideOf(stack.ipop()));
                }
                        Severity: Major
                        Found in bb-tools/proguard4.7/src/proguard/evaluation/Processor.java and 3 other locations - About 30 mins to fix
                        bb-tools/proguard4.7/src/proguard/evaluation/Processor.java on lines 280..293
                        bb-tools/proguard4.7/src/proguard/evaluation/Processor.java on lines 303..316
                        bb-tools/proguard4.7/src/proguard/evaluation/Processor.java on lines 318..331

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 42.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 3 locations. Consider refactoring.
                        Open

                                    case InstructionConstants.OP_DCMPL:
                DoubleValue doubleValue1 = stack.dpop();
                DoubleValue doubleValue2 = stack.dpop();
                stack.push(doubleValue2.compare(doubleValue1));
                break;
                        Severity: Minor
                        Found in bb-tools/proguard4.7/src/proguard/evaluation/Processor.java and 2 other locations - About 30 mins to fix
                        bb-tools/proguard4.7/src/proguard/evaluation/Processor.java on lines 465..471
                        bb-tools/proguard4.7/src/proguard/evaluation/Processor.java on lines 473..477

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 40.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 3 locations. Consider refactoring.
                        Open

                                    case InstructionConstants.OP_LCMP:
//                stack.push(stack.lpop().compareReverse(stack.lpop()));

                LongValue longValue1 = stack.lpop();
                LongValue longValue2 = stack.lpop();
                        Severity: Minor
                        Found in bb-tools/proguard4.7/src/proguard/evaluation/Processor.java and 2 other locations - About 30 mins to fix
                        bb-tools/proguard4.7/src/proguard/evaluation/Processor.java on lines 473..477
                        bb-tools/proguard4.7/src/proguard/evaluation/Processor.java on lines 483..487

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 40.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 3 locations. Consider refactoring.
                        Open

                                    case InstructionConstants.OP_FCMPL:
                FloatValue floatValue1 = stack.fpop();
                FloatValue floatValue2 = stack.fpop();
                stack.push(floatValue2.compare(floatValue1));
                break;
                        Severity: Minor
                        Found in bb-tools/proguard4.7/src/proguard/evaluation/Processor.java and 2 other locations - About 30 mins to fix
                        bb-tools/proguard4.7/src/proguard/evaluation/Processor.java on lines 465..471
                        bb-tools/proguard4.7/src/proguard/evaluation/Processor.java on lines 483..487

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 40.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status