hackedteam/core-blackberry

View on GitHub
bb-tools/proguard4.7/src/proguard/io/ManifestRewriter.java

Summary

Maintainability
A
3 hrs
Test Coverage

Method read has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

        public int read() throws IOException
        {
            while (true)
            {
                if (bufferIndex < bufferSize)
Severity: Minor
Found in bb-tools/proguard4.7/src/proguard/io/ManifestRewriter.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method read has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        public int read() throws IOException
        {
            while (true)
            {
                if (bufferIndex < bufferSize)
Severity: Minor
Found in bb-tools/proguard4.7/src/proguard/io/ManifestRewriter.java - About 1 hr to fix

    Method write has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            public void write(int c) throws IOException
            {
                // TODO: We should actually count the Utf-8 bytes, not the characters.
                if (c == '\n')
                {
    Severity: Minor
    Found in bb-tools/proguard4.7/src/proguard/io/ManifestRewriter.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status