Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star
bb-tools/proguard4.7/src/proguard/optimize/info/SideEffectInstructionChecker.java

Summary

Maintainability
C
1 day
Test Coverage

Consider simplifying this complex logical expression.
Open

        if (opcode == InstructionConstants.OP_IASTORE      ||
            opcode == InstructionConstants.OP_LASTORE      ||
            opcode == InstructionConstants.OP_FASTORE      ||
            opcode == InstructionConstants.OP_DASTORE      ||
            opcode == InstructionConstants.OP_AASTORE      ||
Severity: Critical
Found in bb-tools/proguard4.7/src/proguard/optimize/info/SideEffectInstructionChecker.java - About 4 hrs to fix

    Consider simplifying this complex logical expression.
    Open

            if (opcode == InstructionConstants.OP_GETSTATIC       ||
            opcode == InstructionConstants.OP_PUTSTATIC       ||
            opcode == InstructionConstants.OP_GETFIELD        ||
            opcode == InstructionConstants.OP_PUTFIELD        ||
            opcode == InstructionConstants.OP_INVOKEVIRTUAL   ||
    Severity: Critical
    Found in bb-tools/proguard4.7/src/proguard/optimize/info/SideEffectInstructionChecker.java - About 1 hr to fix

      Method visitConstantInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public void visitConstantInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, ConstantInstruction constantInstruction)
      Severity: Minor
      Found in bb-tools/proguard4.7/src/proguard/optimize/info/SideEffectInstructionChecker.java - About 35 mins to fix

        Method visitSimpleInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public void visitSimpleInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, SimpleInstruction simpleInstruction)
        Severity: Minor
        Found in bb-tools/proguard4.7/src/proguard/optimize/info/SideEffectInstructionChecker.java - About 35 mins to fix

          Method visitVariableInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public void visitVariableInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, VariableInstruction variableInstruction)
          Severity: Minor
          Found in bb-tools/proguard4.7/src/proguard/optimize/info/SideEffectInstructionChecker.java - About 35 mins to fix

            Method hasSideEffects has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public boolean hasSideEffects(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, Instruction instruction)
            Severity: Minor
            Found in bb-tools/proguard4.7/src/proguard/optimize/info/SideEffectInstructionChecker.java - About 35 mins to fix

              Method visitAnyInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public void visitAnyInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, Instruction instruction) {}
              Severity: Minor
              Found in bb-tools/proguard4.7/src/proguard/optimize/info/SideEffectInstructionChecker.java - About 35 mins to fix

                Method visitBranchInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public void visitBranchInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, BranchInstruction branchInstruction)
                Severity: Minor
                Found in bb-tools/proguard4.7/src/proguard/optimize/info/SideEffectInstructionChecker.java - About 35 mins to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          if (opcode == InstructionConstants.OP_IASTORE      ||
            opcode == InstructionConstants.OP_LASTORE      ||
            opcode == InstructionConstants.OP_FASTORE      ||
            opcode == InstructionConstants.OP_DASTORE      ||
            opcode == InstructionConstants.OP_AASTORE      ||
                  Severity: Major
                  Found in bb-tools/proguard4.7/src/proguard/optimize/info/SideEffectInstructionChecker.java and 1 other location - About 1 hr to fix
                  bb-tools/proguard4.7/src/proguard/optimize/info/SideEffectInstructionChecker.java on lines 126..134

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 88.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          if (opcode == InstructionConstants.OP_GETSTATIC       ||
            opcode == InstructionConstants.OP_PUTSTATIC       ||
            opcode == InstructionConstants.OP_GETFIELD        ||
            opcode == InstructionConstants.OP_PUTFIELD        ||
            opcode == InstructionConstants.OP_INVOKEVIRTUAL   ||
                  Severity: Major
                  Found in bb-tools/proguard4.7/src/proguard/optimize/info/SideEffectInstructionChecker.java and 1 other location - About 1 hr to fix
                  bb-tools/proguard4.7/src/proguard/optimize/info/SideEffectInstructionChecker.java on lines 83..91

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 88.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status