hackedteam/core-blackberry

View on GitHub
bb-tools/proguard4.7/src/proguard/optimize/info/VariableUsageMarker.java

Summary

Maintainability
A
1 hr
Test Coverage

Method visitAnyInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public void visitAnyInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, Instruction instruction) {}
Severity: Minor
Found in bb-tools/proguard4.7/src/proguard/optimize/info/VariableUsageMarker.java - About 35 mins to fix

    Method visitVariableInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public void visitVariableInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, VariableInstruction variableInstruction)
    Severity: Minor
    Found in bb-tools/proguard4.7/src/proguard/optimize/info/VariableUsageMarker.java - About 35 mins to fix

      Identical blocks of code found in 4 locations. Consider refactoring.
      Open

              if (variableUsed.length < maxLocals)
              {
                  // Create a new array.
                  variableUsed = new boolean[maxLocals];
              }
      bb-tools/proguard4.7/src/proguard/classfile/editor/VariableEditor.java on lines 56..65
      bb-tools/proguard4.7/src/proguard/optimize/evaluation/EvaluationShrinker.java on lines 1706..1713
      bb-tools/proguard4.7/src/proguard/optimize/peephole/ReachableCodeMarker.java on lines 88..97

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 40.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status