Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star
bb-tools/proguard4.7/src/proguard/optimize/peephole/BranchTargetFinder.java

Summary

Maintainability
D
2 days
Test Coverage

File BranchTargetFinder.java has 362 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * ProGuard -- shrinking, optimization, obfuscation, and preverification
 *             of Java bytecode.
 *
 * Copyright (c) 2002-2011 Eric Lafortune (eric@graphics.cornell.edu)
Severity: Minor
Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/BranchTargetFinder.java - About 4 hrs to fix

    BranchTargetFinder has 35 methods (exceeds 20 allowed). Consider refactoring.
    Open

    public class BranchTargetFinder
extends      SimplifiedVisitor
implements   AttributeVisitor,
             InstructionVisitor,
             ExceptionInfoVisitor,
    Severity: Minor
    Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/BranchTargetFinder.java - About 4 hrs to fix

      Method visitCodeAttribute has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
      Open

          public void visitCodeAttribute(Clazz clazz, Method method, CodeAttribute codeAttribute)
    {
//        DEBUG =
//            clazz.getName().equals("abc/Def") &&
//            method.getName(clazz).equals("abc");
      Severity: Minor
      Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/BranchTargetFinder.java - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method visitCodeAttribute has 95 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public void visitCodeAttribute(Clazz clazz, Method method, CodeAttribute codeAttribute)
    {
//        DEBUG =
//            clazz.getName().equals("abc/Def") &&
//            method.getName(clazz).equals("abc");
      Severity: Major
      Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/BranchTargetFinder.java - About 3 hrs to fix

        Method visitConstantInstruction has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public void visitConstantInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, ConstantInstruction constantInstruction)
    {
        // Mark the instruction.
        instructionMarks[offset] |= INSTRUCTION;
        Severity: Minor
        Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/BranchTargetFinder.java - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Consider simplifying this complex logical expression.
        Open

                if (opcode == InstructionConstants.OP_IRETURN ||
            opcode == InstructionConstants.OP_LRETURN ||
            opcode == InstructionConstants.OP_FRETURN ||
            opcode == InstructionConstants.OP_DRETURN ||
            opcode == InstructionConstants.OP_ARETURN ||
        Severity: Major
        Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/BranchTargetFinder.java - About 40 mins to fix

          Method visitBranchInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public void visitBranchInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, BranchInstruction branchInstruction)
          Severity: Minor
          Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/BranchTargetFinder.java - About 35 mins to fix

            Method visitVariableInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public void visitVariableInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, VariableInstruction variableInstruction)
            Severity: Minor
            Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/BranchTargetFinder.java - About 35 mins to fix

              Method visitSimpleInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public void visitSimpleInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, SimpleInstruction simpleInstruction)
              Severity: Minor
              Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/BranchTargetFinder.java - About 35 mins to fix

                Method visitAnySwitchInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public void visitAnySwitchInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, SwitchInstruction switchInstruction)
                Severity: Minor
                Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/BranchTargetFinder.java - About 35 mins to fix

                  Method visitConstantInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      public void visitConstantInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, ConstantInstruction constantInstruction)
                  Severity: Minor
                  Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/BranchTargetFinder.java - About 35 mins to fix

                    There are no issues that match your filters.

                    Category
                    Status