Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star
bb-tools/proguard4.7/src/proguard/optimize/peephole/GotoCommonCodeReplacer.java

Summary

Maintainability
C
1 day
Test Coverage

Method visitBranchInstruction has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    public void visitBranchInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, BranchInstruction branchInstruction)
    {
        // Check if the instruction is an unconditional goto instruction that
        // isn't the target of a branch itself.
        byte opcode = branchInstruction.opcode;
Severity: Minor
Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/GotoCommonCodeReplacer.java - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method commonByteCodeCount has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    private int commonByteCodeCount(CodeAttribute codeAttribute, int offset1, int offset2)
    {
        // Find the block of common instructions preceding it.
        byte[] code = codeAttribute.code;
Severity: Minor
Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/GotoCommonCodeReplacer.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method commonByteCodeCount has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private int commonByteCodeCount(CodeAttribute codeAttribute, int offset1, int offset2)
    {
        // Find the block of common instructions preceding it.
        byte[] code = codeAttribute.code;
Severity: Minor
Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/GotoCommonCodeReplacer.java - About 1 hr to fix

    Method visitBranchInstruction has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public void visitBranchInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, BranchInstruction branchInstruction)
    {
        // Check if the instruction is an unconditional goto instruction that
        // isn't the target of a branch itself.
        byte opcode = branchInstruction.opcode;
    Severity: Minor
    Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/GotoCommonCodeReplacer.java - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

                      if (branchTargetFinder.isBranchOrigin(newOffset1)   ||
                    branchTargetFinder.isBranchTarget(newOffset1)   ||
                    branchTargetFinder.isExceptionStart(newOffset1) ||
                    branchTargetFinder.isExceptionEnd(newOffset1)   ||
                    branchTargetFinder.isInitializer(newOffset1)    ||
      Severity: Critical
      Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/GotoCommonCodeReplacer.java - About 1 hr to fix

        Method visitAnyInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public void visitAnyInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, Instruction instruction) {}
        Severity: Minor
        Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/GotoCommonCodeReplacer.java - About 35 mins to fix

          Method visitBranchInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public void visitBranchInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, BranchInstruction branchInstruction)
          Severity: Minor
          Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/GotoCommonCodeReplacer.java - About 35 mins to fix

            There are no issues that match your filters.

            Category
            Status