Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star
bb-tools/proguard4.7/src/proguard/optimize/peephole/GotoGotoReplacer.java

Summary

Maintainability
A
3 hrs
Test Coverage

Method visitBranchInstruction has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    public void visitBranchInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, BranchInstruction branchInstruction)
    {
        // Check if the instruction is an unconditional goto instruction.
        byte opcode = branchInstruction.opcode;
        if (opcode == InstructionConstants.OP_GOTO ||
Severity: Minor
Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/GotoGotoReplacer.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method visitBranchInstruction has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public void visitBranchInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, BranchInstruction branchInstruction)
    {
        // Check if the instruction is an unconditional goto instruction.
        byte opcode = branchInstruction.opcode;
        if (opcode == InstructionConstants.OP_GOTO ||
Severity: Minor
Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/GotoGotoReplacer.java - About 1 hr to fix

    Method visitBranchInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public void visitBranchInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, BranchInstruction branchInstruction)
    Severity: Minor
    Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/GotoGotoReplacer.java - About 35 mins to fix

      Method visitAnyInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public void visitAnyInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, Instruction instruction) {}
      Severity: Minor
      Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/GotoGotoReplacer.java - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status