Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star
bb-tools/proguard4.7/src/proguard/optimize/peephole/MethodInliner.java

Summary

Maintainability
F
4 days
Test Coverage

Consider simplifying this complex logical expression.
Open

        if (// Only inline the method if it is private, static, or final.
            (accessFlags & (ClassConstants.INTERNAL_ACC_PRIVATE |
                            ClassConstants.INTERNAL_ACC_STATIC  |
                            ClassConstants.INTERNAL_ACC_FINAL)) != 0                              &&
Severity: Critical
Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/MethodInliner.java - About 6 hrs to fix

    File MethodInliner.java has 353 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
 * ProGuard -- shrinking, optimization, obfuscation, and preverification
 *             of Java bytecode.
 *
 * Copyright (c) 2002-2011 Eric Lafortune (eric@graphics.cornell.edu)
    Severity: Minor
    Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/MethodInliner.java - About 4 hrs to fix

      Method storeParameters has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private void storeParameters(Clazz clazz, Method method)
    {
        String descriptor = method.getDescriptor(clazz);

        boolean isStatic =
      Severity: Major
      Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/MethodInliner.java - About 2 hrs to fix

        Method visitProgramMethod has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            public void visitProgramMethod(ProgramClass programClass, ProgramMethod programMethod)
    {
        int accessFlags = programMethod.getAccessFlags();

        if (// Only inline the method if it is private, static, or final.
        Severity: Minor
        Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/MethodInliner.java - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method visitProgramMethod has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public void visitProgramMethod(ProgramClass programClass, ProgramMethod programMethod)
    {
        int accessFlags = programMethod.getAccessFlags();

        if (// Only inline the method if it is private, static, or final.
        Severity: Minor
        Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/MethodInliner.java - About 1 hr to fix

          Method visitCodeAttribute0 has 43 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public void visitCodeAttribute0(Clazz clazz, Method method, CodeAttribute codeAttribute)
    {
        if (!inlining)
        {
//            codeAttributeComposer.DEBUG = DEBUG =
          Severity: Minor
          Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/MethodInliner.java - About 1 hr to fix

            Method visitConstantInstruction has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public void visitConstantInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, ConstantInstruction constantInstruction)
    {
        // Is it a method invocation?
        switch (constantInstruction.opcode)
        {
            Severity: Minor
            Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/MethodInliner.java - About 1 hr to fix

              Method storeParameters has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                  private void storeParameters(Clazz clazz, Method method)
    {
        String descriptor = method.getDescriptor(clazz);

        boolean isStatic =
              Severity: Minor
              Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/MethodInliner.java - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method visitCodeAttribute0 has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                  public void visitCodeAttribute0(Clazz clazz, Method method, CodeAttribute codeAttribute)
    {
        if (!inlining)
        {
//            codeAttributeComposer.DEBUG = DEBUG =
              Severity: Minor
              Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/MethodInliner.java - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method visitSimpleInstruction has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public void visitSimpleInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, SimpleInstruction simpleInstruction)
    {
        // Are we inlining this instruction?
        if (inlining)
        {
              Severity: Minor
              Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/MethodInliner.java - About 1 hr to fix

                Method visitCodeAttribute has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public void visitCodeAttribute(Clazz clazz, Method method, CodeAttribute codeAttribute)
    {
        // TODO: Remove this when the method inliner has stabilized.
        // Catch any unexpected exceptions from the actual visiting method.
        try
                Severity: Minor
                Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/MethodInliner.java - About 1 hr to fix

                  Method visitConstantInstruction has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public void visitConstantInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, ConstantInstruction constantInstruction)
    {
        // Is it a method invocation?
        switch (constantInstruction.opcode)
        {
                  Severity: Minor
                  Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/MethodInliner.java - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method visitCodeAttribute has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public void visitCodeAttribute(Clazz clazz, Method method, CodeAttribute codeAttribute)
    {
        // TODO: Remove this when the method inliner has stabilized.
        // Catch any unexpected exceptions from the actual visiting method.
        try
                  Severity: Minor
                  Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/MethodInliner.java - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method visitSimpleInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      public void visitSimpleInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, SimpleInstruction simpleInstruction)
                  Severity: Minor
                  Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/MethodInliner.java - About 35 mins to fix

                    Method visitAnyInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public void visitAnyInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, Instruction instruction)
                    Severity: Minor
                    Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/MethodInliner.java - About 35 mins to fix

                      Method visitConstantInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          public void visitConstantInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, ConstantInstruction constantInstruction)
                      Severity: Minor
                      Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/MethodInliner.java - About 35 mins to fix

                        Method visitVariableInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            public void visitVariableInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, VariableInstruction variableInstruction)
                        Severity: Minor
                        Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/MethodInliner.java - About 35 mins to fix

                          Method visitSimpleInstruction has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public void visitSimpleInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, SimpleInstruction simpleInstruction)
    {
        // Are we inlining this instruction?
        if (inlining)
        {
                          Severity: Minor
                          Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/MethodInliner.java - About 35 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                          switch (parameterType.charAt(0))
                {
                    case ClassConstants.INTERNAL_TYPE_BOOLEAN:
                    case ClassConstants.INTERNAL_TYPE_BYTE:
                    case ClassConstants.INTERNAL_TYPE_CHAR:
                          Severity: Major
                          Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/MethodInliner.java and 1 other location - About 1 hr to fix
                          bb-tools/proguard4.7/src/proguard/optimize/TailRecursionSimplifier.java on lines 315..340

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 118.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                      (accessFlags & (ClassConstants.INTERNAL_ACC_PRIVATE |
                            ClassConstants.INTERNAL_ACC_STATIC  |
                            ClassConstants.INTERNAL_ACC_FINAL)) != 0                              &&

            // Only inline the method if it is not synchronized, etc.
                          Severity: Minor
                          Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/MethodInliner.java and 1 other location - About 55 mins to fix
                          bb-tools/proguard4.7/src/proguard/optimize/TailRecursionSimplifier.java on lines 94..102

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 64.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  for (int parameterIndex = 0; parameterIndex < parameterSize; parameterIndex++)
        {
            String parameterType = internalTypeEnumeration.nextType();
            parameterTypes[parameterIndex] = parameterType;
            if (ClassUtil.internalTypeSize(parameterType) == 2)
                          Severity: Minor
                          Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/MethodInliner.java and 1 other location - About 50 mins to fix
                          bb-tools/proguard4.7/src/proguard/optimize/TailRecursionSimplifier.java on lines 295..303

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 62.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                          System.out.println("MethodInliner: inlining ["+
                                   clazz.getName()+"."+method.getName(clazz)+method.getDescriptor(clazz)+"] in ["+
                                   targetClass.getName()+"."+targetMethod.getName(targetClass)+targetMethod.getDescriptor(targetClass)+"]");
                          Severity: Minor
                          Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/MethodInliner.java and 1 other location - About 40 mins to fix
                          bb-tools/proguard4.7/src/proguard/optimize/DuplicateInitializerInvocationFixer.java on lines 120..120

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 50.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status