Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star
bb-tools/proguard4.7/src/proguard/optimize/peephole/ReachableCodeMarker.java

Summary

Maintainability
B
5 hrs
Test Coverage

Consider simplifying this complex logical expression.
Open

        if (opcode == InstructionConstants.OP_IRETURN ||
            opcode == InstructionConstants.OP_LRETURN ||
            opcode == InstructionConstants.OP_FRETURN ||
            opcode == InstructionConstants.OP_DRETURN ||
            opcode == InstructionConstants.OP_ARETURN ||
Severity: Major
Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/ReachableCodeMarker.java - About 1 hr to fix

    Method visitSimpleInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public void visitSimpleInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, SimpleInstruction simpleInstruction)
    Severity: Minor
    Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/ReachableCodeMarker.java - About 35 mins to fix

      Method visitConstantInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public void visitConstantInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, ConstantInstruction constantInstruction)
      Severity: Minor
      Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/ReachableCodeMarker.java - About 35 mins to fix

        Method visitVariableInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public void visitVariableInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, VariableInstruction variableInstruction)
        Severity: Minor
        Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/ReachableCodeMarker.java - About 35 mins to fix

          Method visitBranchInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public void visitBranchInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, BranchInstruction branchInstruction)
          Severity: Minor
          Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/ReachableCodeMarker.java - About 35 mins to fix

            Method markBranchTargets has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                private void markBranchTargets(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, int[] jumpOffsets)
            Severity: Minor
            Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/ReachableCodeMarker.java - About 35 mins to fix

              Method visitAnySwitchInstruction has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public void visitAnySwitchInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, SwitchInstruction switchInstruction)
              Severity: Minor
              Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/ReachableCodeMarker.java - About 35 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        for (int index = 0; index < jumpOffsets.length; index++)
        {
            markCode(clazz, method, codeAttribute, offset + jumpOffsets[index]);
        }
                Severity: Minor
                Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/ReachableCodeMarker.java and 1 other location - About 30 mins to fix
                bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/StackSizeComputer.java on lines 233..240

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 42.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 4 locations. Consider refactoring.
                Open

                        if (isReachable.length < codeLength)
        {
            // Create a new array.
            isReachable = new boolean[codeLength];
        }
                Severity: Major
                Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/ReachableCodeMarker.java and 3 other locations - About 30 mins to fix
                bb-tools/proguard4.7/src/proguard/classfile/editor/VariableEditor.java on lines 56..65
                bb-tools/proguard4.7/src/proguard/optimize/evaluation/EvaluationShrinker.java on lines 1706..1713
                bb-tools/proguard4.7/src/proguard/optimize/info/VariableUsageMarker.java on lines 65..74

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 40.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status