Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star
bb-tools/proguard4.7/src/proguard/optimize/peephole/TargetClassChanger.java

Summary

Maintainability
C
1 day
Test Coverage

TargetClassChanger has 31 methods (exceeds 20 allowed). Consider refactoring.
Open

public class TargetClassChanger
extends      SimplifiedVisitor
implements   ClassVisitor,
             ConstantVisitor,
             MemberVisitor,
Severity: Minor
Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/TargetClassChanger.java - About 3 hrs to fix

    File TargetClassChanger.java has 259 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
 * ProGuard -- shrinking, optimization, obfuscation, and preverification
 *             of Java bytecode.
 *
 * Copyright (c) 2002-2011 Eric Lafortune (eric@graphics.cornell.edu)
    Severity: Minor
    Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/TargetClassChanger.java - About 2 hrs to fix

      Method visitProgramClass has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public void visitProgramClass(ProgramClass programClass)
    {
        // Change the references of the constant pool.
        programClass.constantPoolEntriesAccept(this);
      Severity: Minor
      Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/TargetClassChanger.java - About 1 hr to fix

        Method visitProgramClass has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public void visitProgramClass(ProgramClass programClass)
    {
        // Change the references of the constant pool.
        programClass.constantPoolEntriesAccept(this);
        Severity: Minor
        Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/TargetClassChanger.java - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        System.out.println("  ["+clazz.getName()+"] changing reference from ["+refConstant.referencedClass+"."+refConstant.referencedMember.getName(refConstant.referencedClass)+refConstant.referencedMember.getDescriptor(refConstant.referencedClass)+"]");
        Severity: Minor
        Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/TargetClassChanger.java and 1 other location - About 50 mins to fix
        bb-tools/proguard4.7/src/proguard/optimize/peephole/TargetClassChanger.java on lines 214..214

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 58.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        System.out.println("  ["+clazz.getName()+"]                    to   ["+refConstant.referencedClass+"."+refConstant.referencedMember.getName(refConstant.referencedClass)+refConstant.referencedMember.getDescriptor(refConstant.referencedClass)+"]");
        Severity: Minor
        Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/TargetClassChanger.java and 1 other location - About 50 mins to fix
        bb-tools/proguard4.7/src/proguard/optimize/peephole/TargetClassChanger.java on lines 199..199

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 58.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                for (int index = 0; index < referencedClasses.length; index++)
        {
            referencedClasses[index] =
                updateReferencedClass(referencedClasses[index]);
        }
        Severity: Minor
        Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/TargetClassChanger.java and 2 other locations - About 30 mins to fix
        bb-tools/proguard4.7/src/proguard/classfile/editor/CodeAttributeEditor.java on lines 1025..1028
        bb-tools/proguard4.7/src/proguard/classfile/util/InstructionSequenceMatcher.java on lines 170..173

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 40.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status