Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star
bb-tools/proguard4.7/src/proguard/preverify/CodePreverifier.java

Summary

Maintainability
F
4 days
Test Coverage

File CodePreverifier.java has 380 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * ProGuard -- shrinking, optimization, obfuscation, and preverification
 *             of Java bytecode.
 *
 * Copyright (c) 2002-2011 Eric Lafortune (eric@graphics.cornell.edu)
Severity: Minor
Found in bb-tools/proguard4.7/src/proguard/preverify/CodePreverifier.java - About 5 hrs to fix

    Method visitCodeAttribute0 has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
    Open

        public void visitCodeAttribute0(Clazz clazz, Method method, CodeAttribute codeAttribute)
    {
//        DEBUG =
//            clazz.getName().equals("abc/Def") &&
//            method.getName(clazz).equals("abc");
    Severity: Minor
    Found in bb-tools/proguard4.7/src/proguard/preverify/CodePreverifier.java - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method visitCodeAttribute0 has 97 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public void visitCodeAttribute0(Clazz clazz, Method method, CodeAttribute codeAttribute)
    {
//        DEBUG =
//            clazz.getName().equals("abc/Def") &&
//            method.getName(clazz).equals("abc");
    Severity: Major
    Found in bb-tools/proguard4.7/src/proguard/preverify/CodePreverifier.java - About 3 hrs to fix

      Method correspondingVerificationType has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
      Open

          private VerificationType correspondingVerificationType(ProgramClass  programClass,
                                                           ProgramMethod programMethod,
                                                           CodeAttribute codeAttribute,
                                                           int           offset,
                                                           boolean       isVariable0,
      Severity: Minor
      Found in bb-tools/proguard4.7/src/proguard/preverify/CodePreverifier.java - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method correspondingVerificationTypes has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

          private VerificationType[] correspondingVerificationTypes(ProgramClass    programClass,
                                                              ProgramMethod   programMethod,
                                                              CodeAttribute   codeAttribute,
                                                              int             offset,
                                                              TracedVariables variables)
      Severity: Minor
      Found in bb-tools/proguard4.7/src/proguard/preverify/CodePreverifier.java - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method compressStackMapFrames has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private void compressStackMapFrames(VerificationType[] initialVariableTypes,
                                        List               stackMapFrameList)
    {
        int                previousVariablesCount = initialVariableTypes.length;
        VerificationType[] previousVariableTypes  = initialVariableTypes;
      Severity: Major
      Found in bb-tools/proguard4.7/src/proguard/preverify/CodePreverifier.java - About 2 hrs to fix

        Method correspondingVerificationType has 49 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private VerificationType correspondingVerificationType(ProgramClass  programClass,
                                                           ProgramMethod programMethod,
                                                           CodeAttribute codeAttribute,
                                                           int           offset,
                                                           boolean       isVariable0,
        Severity: Minor
        Found in bb-tools/proguard4.7/src/proguard/preverify/CodePreverifier.java - About 1 hr to fix

          Method correspondingVerificationTypes has 48 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private VerificationType[] correspondingVerificationTypes(ProgramClass    programClass,
                                                              ProgramMethod   programMethod,
                                                              CodeAttribute   codeAttribute,
                                                              int             offset,
                                                              TracedVariables variables)
          Severity: Minor
          Found in bb-tools/proguard4.7/src/proguard/preverify/CodePreverifier.java - About 1 hr to fix

            Method compressStackMapFrames has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

                private void compressStackMapFrames(VerificationType[] initialVariableTypes,
                                        List               stackMapFrameList)
    {
        int                previousVariablesCount = initialVariableTypes.length;
        VerificationType[] previousVariableTypes  = initialVariableTypes;
            Severity: Minor
            Found in bb-tools/proguard4.7/src/proguard/preverify/CodePreverifier.java - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method correspondingVerificationTypes has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private VerificationType[] correspondingVerificationTypes(ProgramClass  programClass,
                                                              ProgramMethod programMethod,
                                                              CodeAttribute codeAttribute,
                                                              int           offset,
                                                              TracedStack   stack)
            Severity: Minor
            Found in bb-tools/proguard4.7/src/proguard/preverify/CodePreverifier.java - About 1 hr to fix

              Method correspondingVerificationType has 7 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  private VerificationType correspondingVerificationType(ProgramClass  programClass,
                                                           ProgramMethod programMethod,
                                                           CodeAttribute codeAttribute,
                                                           int           offset,
                                                           boolean       isVariable0,
              Severity: Major
              Found in bb-tools/proguard4.7/src/proguard/preverify/CodePreverifier.java - About 50 mins to fix

                Method correspondingVerificationTypes has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    private VerificationType[] correspondingVerificationTypes(ProgramClass  programClass,
                                                              ProgramMethod programMethod,
                                                              CodeAttribute codeAttribute,
                                                              int           offset,
                                                              TracedStack   stack)
                Severity: Minor
                Found in bb-tools/proguard4.7/src/proguard/preverify/CodePreverifier.java - About 35 mins to fix

                  Method correspondingVerificationTypes has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      private VerificationType[] correspondingVerificationTypes(ProgramClass    programClass,
                                                              ProgramMethod   programMethod,
                                                              CodeAttribute   codeAttribute,
                                                              int             offset,
                                                              TracedVariables variables)
                  Severity: Minor
                  Found in bb-tools/proguard4.7/src/proguard/preverify/CodePreverifier.java - About 35 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return VerificationTypeFactory.createObjectType(createClassConstant(programClass, referenceValue));
                    Severity: Major
                    Found in bb-tools/proguard4.7/src/proguard/preverify/CodePreverifier.java - About 30 mins to fix

                      Method correspondingVerificationTypes has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                          private VerificationType[] correspondingVerificationTypes(ProgramClass  programClass,
                                                              ProgramMethod programMethod,
                                                              CodeAttribute codeAttribute,
                                                              int           offset,
                                                              TracedStack   stack)
                      Severity: Minor
                      Found in bb-tools/proguard4.7/src/proguard/preverify/CodePreverifier.java - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method equalVerificationTypes has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                          private boolean equalVerificationTypes(VerificationType[] types1,
                                           VerificationType[] types2,
                                           int                length)
    {
        if (length > 0 &&
                      Severity: Minor
                      Found in bb-tools/proguard4.7/src/proguard/preverify/CodePreverifier.java - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                          public void visitCodeAttribute(Clazz clazz, Method method, CodeAttribute codeAttribute)
    {
        // TODO: Remove this when the preverifier has stabilized.
        // Catch any unexpected exceptions from the actual visiting method.
        try
                      Severity: Major
                      Found in bb-tools/proguard4.7/src/proguard/preverify/CodePreverifier.java and 2 other locations - About 1 hr to fix
                      bb-tools/proguard4.7/src/proguard/classfile/editor/CodeAttributeEditor.java on lines 300..322
                      bb-tools/proguard4.7/src/proguard/optimize/peephole/UnreachableCodeRemover.java on lines 79..101

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 120.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status