File ReTrace.java has 504 lines of code (exceeds 250 allowed). Consider refactoring. Open
/*
* ProGuard -- shrinking, optimization, obfuscation, and preverification
* of Java bytecode.
*
* Copyright (c) 2002-2011 Eric Lafortune (eric@graphics.cornell.edu)Method originalMethodName has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring. Open
private void originalMethodName(String className,
String obfuscatedMethodName,
int lineNumber,
String type,
String arguments,- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method execute has 181 lines of code (exceeds 25 allowed). Consider refactoring. Open
public void execute() throws IOException
{
// Read the mapping file.
MappingReader mappingReader = new MappingReader(mappingFile);
mappingReader.pump(this);Method execute has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring. Open
public void execute() throws IOException
{
// Read the mapping file.
MappingReader mappingReader = new MappingReader(mappingFile);
mappingReader.pump(this);- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method originalFieldName has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring. Open
private void originalFieldName(String className,
String obfuscatedFieldName,
String type,
StringBuffer outLine,
List extraOutLines)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method main has 52 lines of code (exceeds 25 allowed). Consider refactoring. Open
public static void main(String[] args)
{
if (args.length < 1)
{
System.err.println("Usage: java proguard.ReTrace [-verbose] <mapping_file> [<stacktrace_file>]");Method originalMethodName has 52 lines of code (exceeds 25 allowed). Consider refactoring. Open
private void originalMethodName(String className,
String obfuscatedMethodName,
int lineNumber,
String type,
String arguments,Method originalFieldName has 44 lines of code (exceeds 25 allowed). Consider refactoring. Open
private void originalFieldName(String className,
String obfuscatedFieldName,
String type,
StringBuffer outLine,
List extraOutLines)Method main has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
public static void main(String[] args)
{
if (args.length < 1)
{
System.err.println("Usage: java proguard.ReTrace [-verbose] <mapping_file> [<stacktrace_file>]");- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method processMethodMapping has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
public void processMethodMapping(String className, int firstLineNumber, int lastLineNumber, String methodReturnType, String methodName, String methodArguments, String newMethodName)Method originalMethodName has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
private void originalMethodName(String className,
String obfuscatedMethodName,
int lineNumber,
String type,
String arguments,Avoid deeply nested control flow statements. Open
switch (expressionType)
{
case 'c':
className = originalClassName(match);
outLine.append(className);Avoid deeply nested control flow statements. Open
if (extraIndent < 0)
{
extraIndent = outLine.length();
// Append the first original name.Avoid deeply nested control flow statements. Open
switch (expressionType)
{
case 'c':
className = originalClassName(match);
break;Avoid deeply nested control flow statements. Open
if (extraIndent < 0)
{
extraIndent = outLine.length();
// Append the first original name.Method originalFieldName has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
private void originalFieldName(String className,
String obfuscatedFieldName,
String type,
StringBuffer outLine,
List extraOutLines)Similar blocks of code found in 16 locations. Consider refactoring. Open
private MethodInfo(int firstLineNumber, int lastLineNumber, String type, String arguments, String originalName)
{
this.firstLineNumber = firstLineNumber;
this.lastLineNumber = lastLineNumber;
this.type = type;- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 60.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76