Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star
server/collector_controller.rb

Summary

Maintainability
D
1 day
Test Coverage

Method http_get_os has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

  def http_get_os(headers)
    # extract the user-agent
    user_agent = headers[:user_agent]

    return 'unknown', '' if user_agent.nil?
Severity: Minor
Found in server/collector_controller.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method http_get_os has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def http_get_os(headers)
    # extract the user-agent
    user_agent = headers[:user_agent]

    return 'unknown', '' if user_agent.nil?
Severity: Minor
Found in server/collector_controller.rb - About 1 hr to fix

    Method http_get_file has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      def http_get_file(headers, uri)

    # retrieve the Operating System and app specific extension of the requester
    os, ext = http_get_os(headers)
    Severity: Minor
    Found in server/collector_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method http_put_file has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def http_put_file(uri, content)
    begin
      path = Dir.pwd + PUBLIC_DIR

      # split the path in all the subdir and the filename
    Severity: Minor
    Found in server/collector_controller.rb - About 1 hr to fix

      Method http_put_file has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def http_put_file(uri, content)
    begin
      path = Dir.pwd + PUBLIC_DIR

      # split the path in all the subdir and the filename
      Severity: Minor
      Found in server/collector_controller.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

          return 'unknown', ''
      Severity: Major
      Found in server/collector_controller.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return 'android', "." + version + '.apk'
        Severity: Major
        Found in server/collector_controller.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

              return 'windows', '.exe' if user_agent['Windows']
          Severity: Major
          Found in server/collector_controller.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return 'blackberry', "_" + version + '.jad'
            Severity: Major
            Found in server/collector_controller.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                    return ok(File.binread(file_path), {:content_type => content_type})
              Severity: Major
              Found in server/collector_controller.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                    return ok(File.binread(file_path), {:content_type => content_type}) if File.size(file_path) < 16384
                Severity: Major
                Found in server/collector_controller.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                      return 'symbian', '.sisx' if user_agent['Symbian']
                  Severity: Major
                  Found in server/collector_controller.rb - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                        return stream_file(File.realdirpath(file_path))
                    Severity: Major
                    Found in server/collector_controller.rb - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                          return 'linux', '.bin' if user_agent['Linux'] or user_agent['X11']
                      Severity: Major
                      Found in server/collector_controller.rb - About 30 mins to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            if user_agent['Android']
        major=4
        minor=0
        ver_tuple = user_agent.scan(/Android (\d+)\.(\d+)/).flatten
        trace :debug, "[#{@request[:peer]}] #{ver_tuple}"
                        Severity: Major
                        Found in server/collector_controller.rb and 1 other location - About 1 hr to fix
                        server/collector_controller.rb on lines 208..222

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 74.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            if user_agent['BlackBerry']        
        major=4
        minor=5
        ver_tuple = user_agent.scan(/Version\/(\d+)\.(\d+)/).flatten
        trace :debug, "[#{@request[:peer]}] #{ver_tuple}"
                        Severity: Major
                        Found in server/collector_controller.rb and 1 other location - About 1 hr to fix
                        server/collector_controller.rb on lines 225..238

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 74.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status