Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star
server/item.rb

Summary

Maintainability
D
2 days
Test Coverage

File item.rb has 391 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'mongoid'

require_relative '../build'
require_relative '../push'
Severity: Minor
Found in server/item.rb - About 5 hrs to fix

    Method add_infection_files has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

      def add_infection_files
    config = JSON.parse(self.configs.last.config)

    found = false
    Severity: Minor
    Found in server/item.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method add_infection_files has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def add_infection_files
    config = JSON.parse(self.configs.last.config)

    found = false
    Severity: Minor
    Found in server/item.rb - About 1 hr to fix

      Method restat has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

        def restat
    case self._kind
      when 'operation'
        self.stat.size = 0;
        self.stat.grid_size = 0;
      Severity: Minor
      Found in server/item.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method restat has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def restat
    case self._kind
      when 'operation'
        self.stat.size = 0;
        self.stat.grid_size = 0;
      Severity: Minor
      Found in server/item.rb - About 1 hr to fix

        Method upgrade! has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def upgrade!
    return if self.upgradable
    return if self.version.nil?

    factory = ::Item.where({_kind: 'factory', ident: self.ident}).first
        Severity: Minor
        Found in server/item.rb - About 1 hr to fix

          Method clone_instance has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def clone_instance
    return nil if self[:_kind] != 'factory'

    agent = Item.new
    agent._kind = 'agent'
          Severity: Minor
          Found in server/item.rb - About 1 hr to fix

            Method destroy_callback has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def destroy_callback
    # remove the item form any dashboard or recent
    ::User.all.each {|u| u.delete_item(self._id)}
    # remove the item form the alerts
    ::Alert.all.each {|a| a.delete_if_item(self._id)}
            Severity: Minor
            Found in server/item.rb - About 1 hr to fix

              Method upgrade! has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                def upgrade!
    return if self.upgradable
    return if self.version.nil?

    factory = ::Item.where({_kind: 'factory', ident: self.ident}).first
              Severity: Minor
              Found in server/item.rb - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method destroy_callback has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                def destroy_callback
    # remove the item form any dashboard or recent
    ::User.all.each {|u| u.delete_item(self._id)}
    # remove the item form the alerts
    ::Alert.all.each {|a| a.delete_if_item(self._id)}
              Severity: Minor
              Found in server/item.rb - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                        if (not a.stat.last_sync.nil?) and (self.stat.last_sync.nil? or a.stat.last_sync > self.stat.last_sync)
            self.stat.last_sync = a.stat.last_sync
          end
              Severity: Minor
              Found in server/item.rb and 1 other location - About 15 mins to fix
              server/item.rb on lines 116..118

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 25.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                        if (not t.stat.last_sync.nil?) and (self.stat.last_sync.nil? or t.stat.last_sync > self.stat.last_sync)
            self.stat.last_sync = t.stat.last_sync
          end
              Severity: Minor
              Found in server/item.rb and 1 other location - About 15 mins to fix
              server/item.rb on lines 130..132

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 25.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status