Sign upLogin

hackedteam/core-ios

View on GitHub
Star
ios-newsstand-app/newsstand-app/Keyboard/KeyboardKey.swift

Summary

Maintainability
D
2 days
Test Coverage

File KeyboardKey.swift has 390 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import UIKit

// TODO: animation on color set
// TODO: correct corner radius
// TODO: correct colors
Severity: Minor
Found in ios-newsstand-app/newsstand-app/Keyboard/KeyboardKey.swift - About 5 hrs to fix

    Function updateColors has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
    Open

        func updateColors() {
        CATransaction.begin()
        CATransaction.setDisableActions(true)
        
        let switchColors = self.highlighted || self.selected
    Severity: Minor
    Found in ios-newsstand-app/newsstand-app/Keyboard/KeyboardKey.swift - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function updateColors has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        func updateColors() {
        CATransaction.begin()
        CATransaction.setDisableActions(true)
        
        let switchColors = self.highlighted || self.selected
    Severity: Major
    Found in ios-newsstand-app/newsstand-app/Keyboard/KeyboardKey.swift - About 2 hrs to fix

      Function refreshShapes has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          func refreshShapes() {
        // TODO: dunno why this is necessary
        self.background.setNeedsLayout()
        
        self.background.layoutIfNeeded()
      Severity: Minor
      Found in ios-newsstand-app/newsstand-app/Keyboard/KeyboardKey.swift - About 1 hr to fix

        Function refreshShapes has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            func refreshShapes() {
        // TODO: dunno why this is necessary
        self.background.setNeedsLayout()
        
        self.background.layoutIfNeeded()
        Severity: Minor
        Found in ios-newsstand-app/newsstand-app/Keyboard/KeyboardKey.swift - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function layoutSubviews has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            override func layoutSubviews() {
        self.layoutPopupIfNeeded()
        
        var boundingBox = (self.popup != nil ? CGRectUnion(self.bounds, self.popup!.frame) : self.bounds)
        Severity: Minor
        Found in ios-newsstand-app/newsstand-app/Keyboard/KeyboardKey.swift - About 1 hr to fix

          Function layoutSubviews has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              override func layoutSubviews() {
        self.layoutPopupIfNeeded()
        
        var boundingBox = (self.popup != nil ? CGRectUnion(self.bounds, self.popup!.frame) : self.bounds)
          Severity: Minor
          Found in ios-newsstand-app/newsstand-app/Keyboard/KeyboardKey.swift - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  self.label.frame = CGRectMake((self.bounds.width - self.bounds.width * CGFloat(0.8)) / CGFloat(2), 0, self.bounds.width * CGFloat(0.8), self.bounds.height)
          Severity: Major
          Found in ios-newsstand-app/newsstand-app/Keyboard/KeyboardKey.swift and 1 other location - About 1 hr to fix
          ios-newsstand-app/newsstand-app/Keyboard/KeyboardKey.swift on lines 49..49

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 70.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                      self.label.frame = CGRectMake((self.bounds.width - self.bounds.width * CGFloat(0.8)) / CGFloat(2), 0, self.bounds.width * CGFloat(0.8), self.bounds.height)
          Severity: Major
          Found in ios-newsstand-app/newsstand-app/Keyboard/KeyboardKey.swift and 1 other location - About 1 hr to fix
          ios-newsstand-app/newsstand-app/Keyboard/KeyboardKey.swift on lines 250..250

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 70.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      shape.frame = CGRectMake(
                CGFloat((self.bounds.width - size.width) / 2.0),
                CGFloat((self.bounds.height - size.height) / 2.0),
                size.width,
                size.height)
          Severity: Minor
          Found in ios-newsstand-app/newsstand-app/Keyboard/KeyboardKey.swift and 1 other location - About 50 mins to fix
          ios-newsstand-app/newsstand-app/Keyboard/Shapes.swift on lines 86..90

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 61.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status