Sign upLogin

hackedteam/core-ios

View on GitHub
Star
ios-newsstand-app/newsstand-app/Keyboard/KeyboardKeyBackground.swift

Summary

Maintainability
D
1 day
Test Coverage

Function generatePointsForDrawing has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

    func generatePointsForDrawing(bounds: CGRect) {
//        if geoHash[self] != nil {
//            let values = geoHash[self]!
//            
//            self.fillPath = values.0
Severity: Minor
Found in ios-newsstand-app/newsstand-app/Keyboard/KeyboardKeyBackground.swift - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function generatePointsForDrawing has 108 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    func generatePointsForDrawing(bounds: CGRect) {
//        if geoHash[self] != nil {
//            let values = geoHash[self]!
//            
//            self.fillPath = values.0
Severity: Major
Found in ios-newsstand-app/newsstand-app/Keyboard/KeyboardKeyBackground.swift - About 4 hrs to fix

    Function layoutSubviews has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        override func layoutSubviews() {
        if !self.dirty {
            if self.bounds.width == 0 || self.bounds.height == 0 {
                return
            }
    Severity: Minor
    Found in ios-newsstand-app/newsstand-app/Keyboard/KeyboardKeyBackground.swift - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                underPath.addArcWithCenter(CGPointMake(self.arcCenters[0].x, self.arcCenters[0].y - self.underOffset), radius: CGFloat(self.cornerRadius), startAngle: startAngle, endAngle: endAngle, clockwise: false)
    Severity: Minor
    Found in ios-newsstand-app/newsstand-app/Keyboard/KeyboardKeyBackground.swift and 1 other location - About 45 mins to fix
    ios-newsstand-app/newsstand-app/Keyboard/KeyboardKeyBackground.swift on lines 295..295

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                underPath.addArcWithCenter(CGPointMake(self.arcCenters[3].x, self.arcCenters[3].y - self.underOffset), radius: CGFloat(self.cornerRadius), startAngle: startAngle, endAngle: endAngle, clockwise: false)
    Severity: Minor
    Found in ios-newsstand-app/newsstand-app/Keyboard/KeyboardKeyBackground.swift and 1 other location - About 45 mins to fix
    ios-newsstand-app/newsstand-app/Keyboard/KeyboardKeyBackground.swift on lines 289..289

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                var p1 = CGPointMake(
                nextPoint.x - (floatXCorner),
                nextPoint.y + underOffset - (floatYCorner))
    Severity: Minor
    Found in ios-newsstand-app/newsstand-app/Keyboard/KeyboardKeyBackground.swift and 1 other location - About 30 mins to fix
    ios-newsstand-app/newsstand-app/Keyboard/KeyboardKeyBackground.swift on lines 181..183

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 40.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                var p0 = CGPointMake(
                currentPoint.x + (floatXCorner),
                currentPoint.y + underOffset + (floatYCorner))
    Severity: Minor
    Found in ios-newsstand-app/newsstand-app/Keyboard/KeyboardKeyBackground.swift and 1 other location - About 30 mins to fix
    ios-newsstand-app/newsstand-app/Keyboard/KeyboardKeyBackground.swift on lines 184..186

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 40.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status