Sign upLogin

hackedteam/core-ios

View on GitHub
Star

Showing 104 of 104 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            var p0 = CGPointMake(
                currentPoint.x + (floatXCorner),
                currentPoint.y + underOffset + (floatYCorner))
Severity: Minor
Found in ios-newsstand-app/newsstand-app/Keyboard/KeyboardKeyBackground.swift and 1 other location - About 30 mins to fix
ios-newsstand-app/newsstand-app/Keyboard/KeyboardKeyBackground.swift on lines 184..186

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

                return self.uppercaseKeyCap!
Severity: Major
Found in ios-newsstand-app/newsstand-app/Keyboard/KeyboardModel.swift - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                    return ""
    Severity: Major
    Found in ios-newsstand-app/newsstand-app/Keyboard/KeyboardModel.swift - About 30 mins to fix

      Method login has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def login(host, port, user, pass)
    @host = host || '127.0.0.1'
    @port = port || 443
    @http = Net::HTTP.new(@host, @port)
    @http.use_ssl = true
      Severity: Minor
      Found in tools/Debug/rcs-core.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language