hackedteam/core-linux

View on GitHub
core/multilib/i386/usr/share/glib-2.0/gdb/glib.py

Summary

Maintainability
F
2 wks
Test Coverage

Function pretty_printer_lookup has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

def pretty_printer_lookup (val):
    # None yet, want things like hash table and list

    type = val.type.unqualified()

Severity: Minor
Found in core/multilib/i386/usr/share/glib-2.0/gdb/glib.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function next has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

        def next(self):
            if self.ht == 0:
                raise StopIteration
            if self.value != None:
                v = self.value
Severity: Minor
Found in core/multilib/i386/usr/share/glib-2.0/gdb/glib.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function parse_args has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def parse_args (self, arg):
        i = arg.find(" ")
        if i <= 0:
            raise Exception ("No var specified")
        var = arg[:i]
Severity: Minor
Found in core/multilib/i386/usr/share/glib-2.0/gdb/glib.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

    return None
Severity: Major
Found in core/multilib/i386/usr/share/glib-2.0/gdb/glib.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                return GListPrinter(val, "GSList")
    Severity: Major
    Found in core/multilib/i386/usr/share/glib-2.0/gdb/glib.py - About 30 mins to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      Severity: Major
      Found in core/multilib/i386/usr/share/glib-2.0/gdb/glib.py and 1 other location - About 2 wks to fix
      core/multilib/x86_64/usr/share/glib-2.0/gdb/glib.py on lines 0..250

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 1872.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status