Sign upLogin

hackedteam/rcs-collector

View on GitHub
Star
lib/rcs-collector/config.rb

Summary

Maintainability
C
1 day
Test Coverage

Method run! has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.run!(*argv)
    # reopen the class and declare any empty trace method
    # if called from command line, we don't have the trace facility
    self.class_eval do
      def trace(level, message)
Severity: Major
Found in lib/rcs-collector/config.rb - About 2 hrs to fix

    Method run has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

      def run(options)
    if options[:alt_log]
      logfilepath = File.expand_path("../../../log/rcs-collector-config.log", __FILE__)

      @logger = Log4r::Logger.new("migration").tap do |logger|
    Severity: Minor
    Found in lib/rcs-collector/config.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method run has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def run(options)
    if options[:alt_log]
      logfilepath = File.expand_path("../../../log/rcs-collector-config.log", __FILE__)

      @logger = Log4r::Logger.new("migration").tap do |logger|
    Severity: Minor
    Found in lib/rcs-collector/config.rb - About 1 hr to fix

      Method load_from_file has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

        def load_from_file
    trace :info, "Loading configuration file..."
    conf_file = File.join Dir.pwd, CONF_DIR, CONF_FILE

    # load the config in the @global hash
      Severity: Minor
      Found in lib/rcs-collector/config.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method load_from_file has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def load_from_file
    trace :info, "Loading configuration file..."
    conf_file = File.join Dir.pwd, CONF_DIR, CONF_FILE

    # load the config in the @global hash
      Severity: Minor
      Found in lib/rcs-collector/config.rb - About 1 hr to fix

        Avoid too many return statements within this method.
        Open

            return true
        Severity: Major
        Found in lib/rcs-collector/config.rb - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status