Sign upLogin

hackedteam/rcs-collector

View on GitHub
Star
lib/rcs-collector/http_controller.rb

Summary

Maintainability
D
2 days
Test Coverage

Method http_get_os has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

  def http_get_os(headers)
    # extract the user-agent
    user_agent = headers[:user_agent]

    return 'unknown', '' if user_agent.nil?
Severity: Minor
Found in lib/rcs-collector/http_controller.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File http_controller.rb has 285 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require_relative 'sync_protocol'

require 'rcs-common/mime'
require 'rcs-common/crypt'
Severity: Minor
Found in lib/rcs-collector/http_controller.rb - About 2 hrs to fix

    Method http_get_file has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

      def http_get_file(headers, uri, delete=true)

    # retrieve the Operating System and app specific extension of the requester
    os, ext = http_get_os(headers)
    Severity: Minor
    Found in lib/rcs-collector/http_controller.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method http_get_os has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def http_get_os(headers)
    # extract the user-agent
    user_agent = headers[:user_agent]

    return 'unknown', '' if user_agent.nil?
    Severity: Minor
    Found in lib/rcs-collector/http_controller.rb - About 1 hr to fix

      Method http_put_file has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def http_put_file(uri, content)
    begin
      path = Dir.pwd + PUBLIC_DIR

      # split the path in all the subdir and the filename
      Severity: Minor
      Found in lib/rcs-collector/http_controller.rb - About 1 hr to fix

        Method http_get_file has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def http_get_file(headers, uri, delete=true)

    # retrieve the Operating System and app specific extension of the requester
    os, ext = http_get_os(headers)
        Severity: Minor
        Found in lib/rcs-collector/http_controller.rb - About 1 hr to fix

          Method delete_after_serve has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

            def delete_after_serve(file, os)
    return if Config.instance.global['DONT_DELETE_AFTER_SERVE']
    Thread.new do
      begin
        sleep 10
          Severity: Minor
          Found in lib/rcs-collector/http_controller.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method http_put_file has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

            def http_put_file(uri, content)
    begin
      path = Dir.pwd + PUBLIC_DIR

      # split the path in all the subdir and the filename
          Severity: Minor
          Found in lib/rcs-collector/http_controller.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method push has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            def push
    # only the DB is authorized to send PUSH commands
    unless from_db?(@request[:headers])
      trace :warn, "HACK ALERT: #{@request[:peer]} is trying to send PUSH [#{@request[:uri]}] commands!!!"
      return method_not_allowed
          Severity: Minor
          Found in lib/rcs-collector/http_controller.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

              return not_found if os == 'cydia' and not File.file?(file_path)
          Severity: Major
          Found in lib/rcs-collector/http_controller.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                  return 'blackberry', "_" + version + '.jad'
            Severity: Major
            Found in lib/rcs-collector/http_controller.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                    return 'android', "." + version + '.apk'
              Severity: Major
              Found in lib/rcs-collector/http_controller.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                    return decoy_page unless File.file?(file_path)
                Severity: Major
                Found in lib/rcs-collector/http_controller.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                      return 'windows', '.exe' if user_agent['Windows']
                  Severity: Major
                  Found in lib/rcs-collector/http_controller.rb - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                        return 'symbian', '.sisx' if user_agent['Symbian']
                    Severity: Major
                    Found in lib/rcs-collector/http_controller.rb - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                          return 'cydia', '.deb' if user_agent['Telesphoreo']
                      Severity: Major
                      Found in lib/rcs-collector/http_controller.rb - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                            return stream_file(File.realdirpath(file_path), proc {delete_after_serve(File.realdirpath(file_path), os) if delete})
                        Severity: Major
                        Found in lib/rcs-collector/http_controller.rb - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                              return 'unknown', ''
                          Severity: Major
                          Found in lib/rcs-collector/http_controller.rb - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                return 'linux', '.bin' if user_agent['Linux'] or user_agent['X11']
                            Severity: Major
                            Found in lib/rcs-collector/http_controller.rb - About 30 mins to fix

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                  if user_agent['BlackBerry']    
      major = 4
      minor = 5
      ver_tuple = user_agent.scan(/\/(\d+)\.(\d+)\.\d+/).flatten
      major, minor = ver_tuple unless ver_tuple.empty?
                              Severity: Major
                              Found in lib/rcs-collector/http_controller.rb and 1 other location - About 1 hr to fix
                              lib/rcs-collector/http_controller.rb on lines 319..331

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 56.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                  if user_agent['Android']
      major = 4
      minor = 0
      ver_tuple = user_agent.scan(/Android (\d+)\.(\d+)/).flatten
      major, minor = ver_tuple unless ver_tuple.empty?
                              Severity: Major
                              Found in lib/rcs-collector/http_controller.rb and 1 other location - About 1 hr to fix
                              lib/rcs-collector/http_controller.rb on lines 304..316

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 56.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              There are no issues that match your filters.

                              Category
                              Status