Sign upLogin

hackedteam/rcs-collector

View on GitHub
Star
lib/rcs-collector/rest.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class RESTController has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

class RESTController
  include RCS::Tracer

  STATUS_OK = 200
  STATUS_REDIRECT = 302
Severity: Minor
Found in lib/rcs-collector/rest.rb - About 2 hrs to fix

    Method act! has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

      def act!
    @request[:action] = @request[:method].to_s.downcase.to_sym

    # check we have a valid action
    return bad_request unless public_methods(false).include?(@request[:action])
    Severity: Minor
    Found in lib/rcs-collector/rest.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status