Sign upLogin

hackedteam/rcs-collector

View on GitHub
Star
lib/rcs-collector/sync_protocol.rb

Summary

Maintainability
D
2 days
Test Coverage

Method authenticate_scout has 91 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.authenticate_scout(peer, uri, content, anon_version)
    trace :info, "[#{peer}] Authentication scout required for (#{content.length.to_s} bytes)..."

    begin
      # remove the base64 container
Severity: Major
Found in lib/rcs-collector/sync_protocol.rb - About 3 hrs to fix

    Method authenticate_elite has 77 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def self.authenticate_elite(peer, uri, content, anon_version)
    trace :info, "[#{peer}] Authentication required for (#{content.length.to_s} bytes)..."

    # integrity check (104 byte of data, 112 padded)
    # consider random extra data to disguise the protocol
    Severity: Major
    Found in lib/rcs-collector/sync_protocol.rb - About 3 hrs to fix

      File sync_protocol.rb has 259 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      require_relative 'sessions'
require_relative 'db'
require_relative 'sync_commands'

# from RCS::Common
      Severity: Minor
      Found in lib/rcs-collector/sync_protocol.rb - About 2 hrs to fix

        Method authenticate_scout has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

          def self.authenticate_scout(peer, uri, content, anon_version)
    trace :info, "[#{peer}] Authentication scout required for (#{content.length.to_s} bytes)..."

    begin
      # remove the base64 container
        Severity: Minor
        Found in lib/rcs-collector/sync_protocol.rb - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method authenticate_elite has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

          def self.authenticate_elite(peer, uri, content, anon_version)
    trace :info, "[#{peer}] Authentication required for (#{content.length.to_s} bytes)..."

    # integrity check (104 byte of data, 112 padded)
    # consider random extra data to disguise the protocol
        Severity: Minor
        Found in lib/rcs-collector/sync_protocol.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method commands has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def self.commands(peer, cookie, content)
    # retrieve the session
    session = SessionManager.instance.get cookie

    # invalid session
        Severity: Minor
        Found in lib/rcs-collector/sync_protocol.rb - About 1 hr to fix

          Method commands has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

            def self.commands(peer, cookie, content)
    # retrieve the session
    session = SessionManager.instance.get cookie

    # invalid session
          Severity: Minor
          Found in lib/rcs-collector/sync_protocol.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method parse has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            def self.parse(peer, uri, cookie, content, anon_version)
          Severity: Minor
          Found in lib/rcs-collector/sync_protocol.rb - About 35 mins to fix

            Avoid too many return statements within this method.
            Open

                return message, 'application/octet-stream', cookie
            Severity: Major
            Found in lib/rcs-collector/sync_protocol.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return
              Severity: Major
              Found in lib/rcs-collector/sync_protocol.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                      return
                Severity: Major
                Found in lib/rcs-collector/sync_protocol.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                        return
                  Severity: Major
                  Found in lib/rcs-collector/sync_protocol.rb - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                          return
                    Severity: Major
                    Found in lib/rcs-collector/sync_protocol.rb - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                            return
                      Severity: Major
                      Found in lib/rcs-collector/sync_protocol.rb - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                            return enc_msg, 'application/octet-stream', cookie
                        Severity: Major
                        Found in lib/rcs-collector/sync_protocol.rb - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                return
                          Severity: Major
                          Found in lib/rcs-collector/sync_protocol.rb - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                return response, 'application/octet-stream', cookie
                            Severity: Major
                            Found in lib/rcs-collector/sync_protocol.rb - About 30 mins to fix

                              Identical blocks of code found in 2 locations. Consider refactoring.
                              Open

                                    when DB::DELETED_AGENT, DB::NO_SUCH_AGENT, DB::CLOSED_AGENT
        response = [Commands::PROTO_UNINSTALL].pack('I')
        trace :info, "[#{peer}] Uninstall command sent (#{status})"
        DB.instance.agent_uninstall(aid) unless aid.eql? 0
                              Severity: Minor
                              Found in lib/rcs-collector/sync_protocol.rb and 1 other location - About 25 mins to fix
                              lib/rcs-collector/sync_protocol.rb on lines 329..332

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 31.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Identical blocks of code found in 2 locations. Consider refactoring.
                              Open

                                    when DB::DELETED_AGENT, DB::NO_SUCH_AGENT, DB::CLOSED_AGENT
        response = [Commands::PROTO_UNINSTALL].pack('I')
        trace :info, "[#{peer}] Uninstall command sent (#{status})"
        DB.instance.agent_uninstall(aid) unless aid.eql? 0
                              Severity: Minor
                              Found in lib/rcs-collector/sync_protocol.rb and 1 other location - About 25 mins to fix
                              lib/rcs-collector/sync_protocol.rb on lines 170..173

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 31.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              There are no issues that match your filters.

                              Category
                              Status