hackedteam/rcs-db

View on GitHub
lib/rcs-db/build/symbian.rb

Summary

Maintainability
D
1 day
Test Coverage

Method patch has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

  def patch(params)
    trace :debug, "Build: patching: #{params}"

    # add the file to be patched to the params
    # these params will be passed to the super
Severity: Minor
Found in lib/rcs-db/build/symbian.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_app_info has 79 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def get_app_info(file)
    # Read info from original package

    fd = File.open(file, "rb")
    raise "Invalid input file" unless fd
Severity: Major
Found in lib/rcs-db/build/symbian.rb - About 3 hrs to fix

    Method get_app_info has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

      def get_app_info(file)
        # Read info from original package
    
        fd = File.open(file, "rb")
        raise "Invalid input file" unless fd
    Severity: Minor
    Found in lib/rcs-db/build/symbian.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method sign has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def sign(params)
        trace :debug, "Build: signing: #{params}"
    
        trace :debug, "Build: creating sisx files"
    
    
    Severity: Minor
    Found in lib/rcs-db/build/symbian.rb - About 1 hr to fix

      Method patch has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def patch(params)
          trace :debug, "Build: patching: #{params}"
      
          # add the file to be patched to the params
          # these params will be passed to the super
      Severity: Minor
      Found in lib/rcs-db/build/symbian.rb - About 1 hr to fix

        Method sign has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def sign(params)
            trace :debug, "Build: signing: #{params}"
        
            trace :debug, "Build: creating sisx files"
        
        
        Severity: Minor
        Found in lib/rcs-db/build/symbian.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status