Sign upLogin

hackedteam/rcs-db

View on GitHub
Star
lib/rcs-db/db_objects/collector.rb

Summary

Maintainability
C
1 day
Test Coverage

File collector.rb has 587 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'mongoid'

class Collector
  include Mongoid::Document
  include Mongoid::Timestamps
Severity: Major
Found in lib/rcs-db/db_objects/collector.rb - About 1 day to fix

    Method collector_login has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.collector_login(instance, version, ext_address, local_address)
    coll = Collector.where({type: 'local'}).any_in({instance: [instance]}).first

    # the collector does not exist, check the licence and create it
    if coll.nil?
    Severity: Minor
    Found in lib/rcs-db/db_objects/collector.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status