Sign upLogin

hackedteam/rcs-db

View on GitHub
Star
lib/rcs-db/frontend.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method collector_put has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

  def self.collector_put(filename, content, factory, user)
    begin
      raise "no collector found" if ::Status.where({type: 'collector'}).any_in(status: [::Status::OK, ::Status::WARN]).count == 0

      saved = false
Severity: Minor
Found in lib/rcs-db/frontend.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method proxy has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def self.proxy(method, proto, host, url, content = nil, headers = {})
Severity: Minor
Found in lib/rcs-db/frontend.rb - About 45 mins to fix

    Method collector_del has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.collector_del(filename)
    begin
      raise "no collector found" if ::Status.where({type: 'collector'}).any_in(status: [::Status::OK, ::Status::WARN]).count == 0
      # put the file on every collector, we cannot know where it will be requested
      ::Status.where({type: 'collector'}).any_in(status: [::Status::OK, ::Status::WARN]).each do |collector|
    Severity: Minor
    Found in lib/rcs-db/frontend.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method nc_push has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.nc_push(object)
    begin
      # find a network controller in the status list
      nc = ::Status.where({type: 'nc'}).any_in(status: [::Status::OK, ::Status::WARN]).first
    Severity: Minor
    Found in lib/rcs-db/frontend.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status