Sign upLogin

hackedteam/rcs-db

View on GitHub
Star
lib/rcs-worker/instance_worker.rb

Summary

Maintainability
C
1 day
Test Coverage

Method process has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
Open

      def process(grid_ev)
        start_time = Time.now
        raw_id = grid_ev['_id']

        raise MissingAgentError.new("Unable to process evidence #{raw_id}, agent #{@agent_uid} is missing") unless agent?
Severity: Minor
Found in lib/rcs-worker/instance_worker.rb - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def process(grid_ev)
        start_time = Time.now
        raw_id = grid_ev['_id']

        raise MissingAgentError.new("Unable to process evidence #{raw_id}, agent #{@agent_uid} is missing") unless agent?
Severity: Minor
Found in lib/rcs-worker/instance_worker.rb - About 1 hr to fix

    Method run has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

          def run
        raise MissingAgentError.new("Unable to run instance worker #{@agent_uid}, agent is missing or closed") unless agent?

        trace(:info, "[#{@agent_uid}] Evidence processing started for agent #{agent.name}")
    Severity: Minor
    Found in lib/rcs-worker/instance_worker.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method decrypt_evidence has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

          def decrypt_evidence(raw_id)
        content = RCS::DB::GridFS.get(raw_id, "evidence", :worker) rescue nil
        return unless content

        decoded_data = ''
    Severity: Minor
    Found in lib/rcs-worker/instance_worker.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status