Sign upLogin

hackedteam/test-av

View on GitHub
Star
modules/reporting/metadata.py

Summary

Maintainability
F
3 days
Test Coverage

Function addRelations has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
Open

    def addRelations(self):
        """Adds relationships."""
        # Dropped files
        for file in self.results['dropped']:
            self.relationships.add_relationship(self.createRelation(
Severity: Minor
Found in modules/reporting/metadata.py - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function addObjects has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    def addObjects(self):
        """Adds objects elements."""
        # File objects
        # Subject
        self.objects.add_file(self.createFileObject(self.results['file']))
Severity: Minor
Found in modules/reporting/metadata.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                        if exist.get_id() == req['uri']:
                            found = True
                    if not found:
Severity: Major
Found in modules/reporting/metadata.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                            if res['hostname'] == req.get_hostname():
                            ip = res['ip']
                            # Check if obj exist
                            found = None
                            for obj in self.objects.get_ip():
    Severity: Major
    Found in modules/reporting/metadata.py - About 45 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      for req in self.results['network']['http']:
                    found = False
                    for exist in self.objects.get_uri():
                        if exist.get_id() == req['uri']:
                            found = True
      Severity: Major
      Found in modules/reporting/metadata.py and 1 other location - About 3 hrs to fix
      modules/reporting/metadata.py on lines 56..62

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 68.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  for f in self.results['dropped']:
                found = False
                for exist in self.objects.get_file():
                    if exist.get_md5() == f['md5']:
                        found = True
      Severity: Major
      Found in modules/reporting/metadata.py and 1 other location - About 3 hrs to fix
      modules/reporting/metadata.py on lines 66..72

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 68.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              for file in self.results['dropped']:
            self.relationships.add_relationship(self.createRelation(
                                                                    action = 'installed',
                                                                    src = "file[@id='%s']" % self.results['file']['md5'],
                                                                    dst = "file[@id='%s']" % file['md5']
      Severity: Major
      Found in modules/reporting/metadata.py and 1 other location - About 2 hrs to fix
      modules/reporting/metadata.py on lines 151..155

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 57.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      for req in self.results['network']['http']:
                    self.relationships.add_relationship(self.createRelation(
                                                                            action = 'contactedBy',
                                                                            src = "file[@id='%s']" % self.results['file']['md5'],
                                                                            dst = "uri[@id='%s']" % req['uri']
      Severity: Major
      Found in modules/reporting/metadata.py and 1 other location - About 2 hrs to fix
      modules/reporting/metadata.py on lines 117..121

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 57.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

          def getRelId(self):
        """Generates incremental relation id.
        @return: generated id
        """
        try:
      Severity: Major
      Found in modules/reporting/metadata.py and 5 other locations - About 1 hr to fix
      modules/reporting/maec11.py on lines 54..62
      modules/reporting/maec11.py on lines 64..72
      modules/reporting/maec11.py on lines 74..82
      modules/reporting/maec11.py on lines 84..92
      modules/reporting/maec11.py on lines 94..102

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 43.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status