hackedteam/test-av2

View on GitHub
AVAgent/old/tmp/rest_test.rb

Summary

Maintainability
D
2 days
Test Coverage

File rest_test.rb has 926 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'net/http'
require 'json'
require 'benchmark'
require 'open-uri'
require 'pp'
Severity: Major
Found in AVAgent/old/tmp/rest_test.rb - About 2 days to fix

    Method REST_task has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    def REST_task(http, cookie, type, filename, params={})
      
      task_params = {'type' => type, 'file_name' => filename}
      task_params.merge! params
      
    Severity: Minor
    Found in AVAgent/old/tmp/rest_test.rb - About 1 hr to fix

      Method REST_task has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

      def REST_task(http, cookie, type, filename, params={})
        
        task_params = {'type' => type, 'file_name' => filename}
        task_params.merge! params
        
      Severity: Minor
      Found in AVAgent/old/tmp/rest_test.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method REST_task has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def REST_task(http, cookie, type, filename, params={})
      Severity: Minor
      Found in AVAgent/old/tmp/rest_test.rb - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status