Sign upLogin

hackedteam/test-av2

View on GitHub
Star
AVCommon/commands/client/CROP.py

Summary

Maintainability
B
4 hrs
Test Coverage

Function execute has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

def execute(vm, args):
    from PIL import ImageGrab
    global im1, thread, go_on, found

    if not os.path.exists(config.basedir_crop):
Severity: Minor
Found in AVCommon/commands/client/CROP.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function on_answer has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

def on_answer(vm, success, answer):
    from AVMaster import vm_manager

    #assert command.context, "Null context"
Severity: Minor
Found in AVCommon/commands/client/CROP.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function crop has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

def crop(iter):
    from PIL import ImageGrab
    global im1

    logging.debug("crop: %s" % iter)
Severity: Minor
Found in AVCommon/commands/client/CROP.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function grab_loop has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def grab_loop(vm):
    global go_on, found
    iter=0;
    logging.debug("grab loop")
    if not os.path.exists("crop"):
Severity: Minor
Found in AVCommon/commands/client/CROP.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status