hackedteam/test-av2

View on GitHub
AVCommon/commands/client/UNINSTALL.py

Summary

Maintainability
A
2 hrs
Test Coverage

Function delete_startup has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

def delete_startup():
    logging.debug("deleting startup")
    for d in build.start_dirs:
        for b in build.names:
            filename = "%s/%s.exe" %(d,b)
Severity: Minor
Found in AVCommon/commands/client/UNINSTALL.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function kill_rcs has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

def kill_rcs(vm):

    logging.debug("Killing rcs")

    cmd = 'WMIC PROCESS get Caption,Processid /format:value'
Severity: Minor
Found in AVCommon/commands/client/UNINSTALL.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function kill_proc_by_regex has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

def kill_proc_by_regex(procs, reagent):

    exenames = [ "%s.exe" % n for n in build.names]

    for caption, pid in [ (e['Caption'],int(e['ProcessId'])) for e in procs]:
Severity: Minor
Found in AVCommon/commands/client/UNINSTALL.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status