hackedteam/test-av2

View on GitHub
AVMaster/conf/params.py

Summary

Maintainability
D
1 day
Test Coverage

Similar blocks of code found in 11 locations. Consider refactoring.
Open

params['exploit_docx'] = {"generate":
                              {"platforms": ["windows"], "binary": {"demo": False, "admin": False},
                               "exploit": "HT-2013-002",
                               "melt": {"demo": False, "scout": True, "admin": False}},
                          "platform": "exploit", "deliver": {"user": "USERID"},
Severity: Major
Found in AVMaster/conf/params.py and 10 other locations - About 3 hrs to fix
AVAgent/build.py on lines 1076..1082
AVAgent/build.py on lines 1085..1091
AVAgent/build.py on lines 1093..1099
AVAgent/build.py on lines 1101..1107
AVMaster/conf/params.py on lines 42..47
AVMaster/conf/params.py on lines 58..64
AVMaster/conf/params.py on lines 66..72
scripts/dvd_offline/build.py on lines 123..127
scripts/dvd_offline/build.py on lines 130..134
scripts/dvd_offline/build.py on lines 136..140

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 67.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

params['exploit_ppsx'] = {"generate":
                              {"platforms": ["windows"], "binary": {"demo": False, "admin": False},
                               "exploit": "HT-2013-003",
                               "melt": {"demo": False, "scout": True, "admin": False}},
                          "platform": "exploit", "deliver": {"user": "USERID"},
Severity: Major
Found in AVMaster/conf/params.py and 10 other locations - About 3 hrs to fix
AVAgent/build.py on lines 1076..1082
AVAgent/build.py on lines 1085..1091
AVAgent/build.py on lines 1093..1099
AVAgent/build.py on lines 1101..1107
AVMaster/conf/params.py on lines 42..47
AVMaster/conf/params.py on lines 50..56
AVMaster/conf/params.py on lines 66..72
scripts/dvd_offline/build.py on lines 123..127
scripts/dvd_offline/build.py on lines 130..134
scripts/dvd_offline/build.py on lines 136..140

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 67.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

params['exploit_web'] = {"generate":
                             {"platforms": ["windows"], "binary": {"demo": False, "admin": False},
                              "exploit": "HT-2013-002",
                              "melt": {"demo": False, "scout": True, "admin": False}},
                         "platform": "exploit", "deliver": {"user": "USERID"},
Severity: Major
Found in AVMaster/conf/params.py and 10 other locations - About 3 hrs to fix
AVAgent/build.py on lines 1076..1082
AVAgent/build.py on lines 1085..1091
AVAgent/build.py on lines 1093..1099
AVAgent/build.py on lines 1101..1107
AVMaster/conf/params.py on lines 42..47
AVMaster/conf/params.py on lines 50..56
AVMaster/conf/params.py on lines 58..64
scripts/dvd_offline/build.py on lines 123..127
scripts/dvd_offline/build.py on lines 130..134
scripts/dvd_offline/build.py on lines 136..140

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 67.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

params['exploit'] = {"generate":
                         {"platforms": ["windows"], "binary": {"demo": False, "admin": False}, "exploit": "HT-2012-001",
                          "melt": {"demo": False, "scout": True, "admin": False}}, "platform": "exploit",
                     "deliver": {"user": "USERID"},
                     "melt": {"combo": "txt", "filename": "example.txt", "appname": "agent.exe",
Severity: Major
Found in AVMaster/conf/params.py and 10 other locations - About 3 hrs to fix
AVAgent/build.py on lines 1076..1082
AVAgent/build.py on lines 1085..1091
AVAgent/build.py on lines 1093..1099
AVAgent/build.py on lines 1101..1107
AVMaster/conf/params.py on lines 50..56
AVMaster/conf/params.py on lines 58..64
AVMaster/conf/params.py on lines 66..72
scripts/dvd_offline/build.py on lines 123..127
scripts/dvd_offline/build.py on lines 130..134
scripts/dvd_offline/build.py on lines 136..140

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 67.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

params['blackberry'] = {
    'platform': 'blackberry',
    'binary': {'demo': demo},
    'melt': {'appname': 'facebook',
             'name': 'Facebook Application',
Severity: Major
Found in AVMaster/conf/params.py and 2 other locations - About 1 hr to fix
AVAgent/build.py on lines 1041..1049
scripts/dvd_offline/build.py on lines 91..98

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

params['windows'] = {
    'platform': 'windows',
    'binary': {'demo': demo, 'admin': False},
    'melt': {'scout': True, 'admin': False, 'bit64': True, 'codec': True},
    'sign': {}
Severity: Major
Found in AVMaster/conf/params.py and 2 other locations - About 55 mins to fix
AVAgent/build.py on lines 1050..1054
scripts/dvd_offline/build.py on lines 100..103

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 37.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status