hackedteam/vector-edk

View on GitHub
AppPkg/Applications/Python/Python-2.7.2/Demo/classes/Complex.py

Summary

Maintainability
D
2 days
Test Coverage

Complex has 23 functions (exceeds 20 allowed). Consider refactoring.
Open

class Complex:

    def __init__(self, re=0, im=0):
        _re = 0
        _im = 0
Severity: Minor
Found in AppPkg/Applications/Python/Python-2.7.2/Demo/classes/Complex.py - About 2 hrs to fix

    Function __pow__ has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def __pow__(self, n, z=None):
            if z is not None:
                raise TypeError, 'Complex does not support ternary pow()'
            if IsComplex(n):
                if n.im:
    Severity: Minor
    Found in AppPkg/Applications/Python/Python-2.7.2/Demo/classes/Complex.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function checkop has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def checkop(expr, a, b, value, fuzz = 1e-6):
    Severity: Minor
    Found in AppPkg/Applications/Python/Python-2.7.2/Demo/classes/Complex.py - About 35 mins to fix

      Function test has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      def test():
          print 'test constructors'
          constructor_test = (
              # "expect" is an array [re,im] "got" the Complex.
                  ( (0,0), Complex() ),
      Severity: Minor
      Found in AppPkg/Applications/Python/Python-2.7.2/Demo/classes/Complex.py - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

                  'a*b': [
                          (1, 10, 10),
                          (1, Complex(0,10), Complex(0, 10)),
                          (Complex(0,10), 1, Complex(0,10)),
                          (Complex(0,10), Complex(1), Complex(0,10)),
      AppPkg/Applications/Python/Python-2.7.2/Demo/classes/Complex.py on lines 268..273
      AppPkg/Applications/Python/Python-2.7.2/Demo/classes/Complex.py on lines 275..280
      AppPkg/Applications/Python/Python-2.7.2/Demo/classes/Complex.py on lines 289..294

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 74.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

                  'a-b': [
                          (1, 10, -9),
                          (1, Complex(0,10), Complex(1,-10)),
                          (Complex(0,10), 1, Complex(-1,10)),
                          (Complex(0,10), Complex(1), Complex(-1,10)),
      AppPkg/Applications/Python/Python-2.7.2/Demo/classes/Complex.py on lines 268..273
      AppPkg/Applications/Python/Python-2.7.2/Demo/classes/Complex.py on lines 282..287
      AppPkg/Applications/Python/Python-2.7.2/Demo/classes/Complex.py on lines 289..294

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 74.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

                  'a/b': [
                          (1., 10, 0.1),
                          (1, Complex(0,10), Complex(0, -0.1)),
                          (Complex(0, 10), 1, Complex(0, 10)),
                          (Complex(0, 10), Complex(1), Complex(0, 10)),
      AppPkg/Applications/Python/Python-2.7.2/Demo/classes/Complex.py on lines 268..273
      AppPkg/Applications/Python/Python-2.7.2/Demo/classes/Complex.py on lines 275..280
      AppPkg/Applications/Python/Python-2.7.2/Demo/classes/Complex.py on lines 282..287

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 74.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

                  'a+b': [
                          (1, 10, 11),
                          (1, Complex(0,10), Complex(1,10)),
                          (Complex(0,10), 1, Complex(1,10)),
                          (Complex(0,10), Complex(1), Complex(1,10)),
      AppPkg/Applications/Python/Python-2.7.2/Demo/classes/Complex.py on lines 275..280
      AppPkg/Applications/Python/Python-2.7.2/Demo/classes/Complex.py on lines 282..287
      AppPkg/Applications/Python/Python-2.7.2/Demo/classes/Complex.py on lines 289..294

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 74.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              return Complex(math.cos(phi)*r, math.sin(phi)*r)
      Severity: Minor
      Found in AppPkg/Applications/Python/Python-2.7.2/Demo/classes/Complex.py and 1 other location - About 30 mins to fix
      AppPkg/Applications/Python/Python-2.7.2/Demo/classes/Complex.py on lines 84..84

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 32.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          return Complex(math.cos(phi)*r, math.sin(phi)*r)
      Severity: Minor
      Found in AppPkg/Applications/Python/Python-2.7.2/Demo/classes/Complex.py and 1 other location - About 30 mins to fix
      AppPkg/Applications/Python/Python-2.7.2/Demo/classes/Complex.py on lines 220..220

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 32.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status