Sign upLogin

hackedteam/vector-edk

View on GitHub
Star
AppPkg/Applications/Python/Python-2.7.2/Demo/pdist/FSProxy.py

Summary

Maintainability
D
3 days
Test Coverage

FSProxyLocal has 41 functions (exceeds 20 allowed). Consider refactoring.
Open

class FSProxyLocal:

    def __init__(self):
        self._dirstack = []
        self._ignore = ['*.pyc'] + self._readignore()
Severity: Minor
Found in AppPkg/Applications/Python/Python-2.7.2/Demo/pdist/FSProxy.py - About 5 hrs to fix

    Function visible has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def visible(self, name):
        if len(name) > maxnamelen: return 0
        if name[-1] == '~': return 0
        if name in skipnames: return 0
        if self._hidden(name): return 0
    Severity: Minor
    Found in AppPkg/Applications/Python/Python-2.7.2/Demo/pdist/FSProxy.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _readignore has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def _readignore(self):
        file = self._hide('ignore')
        try:
            f = open(file)
        except IOError:
    Severity: Minor
    Found in AppPkg/Applications/Python/Python-2.7.2/Demo/pdist/FSProxy.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

                if fnmatch.fnmatch(name, ign): return 0
    Severity: Major
    Found in AppPkg/Applications/Python/Python-2.7.2/Demo/pdist/FSProxy.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return 1
      Severity: Major
      Found in AppPkg/Applications/Python/Python-2.7.2/Demo/pdist/FSProxy.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                if head or not tail: return 0
        Severity: Major
        Found in AppPkg/Applications/Python/Python-2.7.2/Demo/pdist/FSProxy.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  if os.path.islink(name): return 0
          Severity: Major
          Found in AppPkg/Applications/Python/Python-2.7.2/Demo/pdist/FSProxy.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    if '\0' in open(name, 'rb').read(512): return 0
            Severity: Major
            Found in AppPkg/Applications/Python/Python-2.7.2/Demo/pdist/FSProxy.py - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              class FSProxyServer(FSProxyLocal, server.Server):

    def __init__(self, address, verbose = server.VERBOSE):
        FSProxyLocal.__init__(self)
        server.Server.__init__(self, address, verbose)
              Severity: Major
              Found in AppPkg/Applications/Python/Python-2.7.2/Demo/pdist/FSProxy.py and 1 other location - About 5 hrs to fix
              AppPkg/Applications/Python/Python-2.7.2/Demo/pdist/RCSProxy.py on lines 152..165

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 97.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              def test():
    import string
    import sys
    if sys.argv[1:]:
        port = string.atoi(sys.argv[1])
              Severity: Major
              Found in AppPkg/Applications/Python/Python-2.7.2/Demo/pdist/FSProxy.py and 1 other location - About 3 hrs to fix
              AppPkg/Applications/Python/Python-2.7.2/Demo/pdist/RCSProxy.py on lines 168..176

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 66.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      for name in list:
            try:
                res.append((name, function(name)))
            except (os.error, IOError):
                res.append((name, None))
              Severity: Major
              Found in AppPkg/Applications/Python/Python-2.7.2/Demo/pdist/FSProxy.py and 1 other location - About 1 hr to fix
              AppPkg/Applications/Python/Python-2.7.2/Demo/pdist/RCSProxy.py on lines 126..130

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                  def listfiles(self, pat = None):
        files = os.listdir(os.curdir)
        files = filter(os.path.isfile, files)
        return self._filter(files, pat)
              Severity: Major
              Found in AppPkg/Applications/Python/Python-2.7.2/Demo/pdist/FSProxy.py and 2 other locations - About 1 hr to fix
              AppPkg/Applications/Python/Python-2.7.2/Demo/pdist/FSProxy.py on lines 124..127
              AppPkg/Applications/Python/Python-2.7.2/Demo/pdist/RCSProxy.py on lines 58..61

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                  def listsubdirs(self, pat = None):
        files = os.listdir(os.curdir)
        files = filter(os.path.isdir, files)
        return self._filter(files, pat)
              Severity: Major
              Found in AppPkg/Applications/Python/Python-2.7.2/Demo/pdist/FSProxy.py and 2 other locations - About 1 hr to fix
              AppPkg/Applications/Python/Python-2.7.2/Demo/pdist/FSProxy.py on lines 119..122
              AppPkg/Applications/Python/Python-2.7.2/Demo/pdist/RCSProxy.py on lines 58..61

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      for name in list:
            try:
                dict[name] = function(name)
            except (os.error, IOError):
              Severity: Minor
              Found in AppPkg/Applications/Python/Python-2.7.2/Demo/pdist/FSProxy.py and 1 other location - About 40 mins to fix
              AppPkg/Applications/Python/Python-2.7.2/Demo/pdist/RCSProxy.py on lines 144..147

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 34.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status