Sign upLogin

hackedteam/vector-edk

View on GitHub
Star
AppPkg/Applications/Python/Python-2.7.2/Lib/CGIHTTPServer.py

Summary

Maintainability
F
3 wks
Test Coverage

Function run_cgi has a Cognitive Complexity of 87 (exceeds 5 allowed). Consider refactoring.
Open

    def run_cgi(self):
        """Execute a CGI script."""
        path = self.path
        dir, rest = self.cgi_info
Severity: Minor
Found in AppPkg/Applications/Python/Python-2.7.2/Lib/CGIHTTPServer.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File CGIHTTPServer.py has 296 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""CGI-savvy HTTP Server.

This module builds on SimpleHTTPServer by implementing GET and POST
requests to cgi-bin scripts.
Severity: Minor
Found in AppPkg/Applications/Python/Python-2.7.2/Lib/CGIHTTPServer.py - About 3 hrs to fix

    Function run_cgi has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def run_cgi(self):
        """Execute a CGI script."""
        path = self.path
        dir, rest = self.cgi_info
    Severity: Minor
    Found in AppPkg/Applications/Python/Python-2.7.2/Lib/CGIHTTPServer.py - About 1 hr to fix

      Function _url_collapse_path_split has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

      def _url_collapse_path_split(path):
    """
    Given a URL path, remove extra '/'s and '.' path elements and collapse
    any '..' references.
      Severity: Minor
      Found in AppPkg/Applications/Python/Python-2.7.2/Lib/CGIHTTPServer.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

                      return
      Severity: Major
      Found in AppPkg/Applications/Python/Python-2.7.2/Lib/CGIHTTPServer.py - About 30 mins to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        Severity: Major
        Found in AppPkg/Applications/Python/Python-2.7.2/Lib/CGIHTTPServer.py and 1 other location - About 3 wks to fix
        vector-uefi/fd/efi/StdLib/lib/python.27/CGIHTTPServer.py on lines 0..374

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 2329.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status