Sign upLogin

hackedteam/vector-edk

View on GitHub
Star
AppPkg/Applications/Python/Python-2.7.2/Lib/StringIO.py

Summary

Maintainability
F
2 wks
Test Coverage

File StringIO.py has 283 lines of code (exceeds 250 allowed). Consider refactoring.
Open

r"""File-like objects that read from or write to a string buffer.

This implements (nearly) all stdio methods.

f = StringIO()      # ready for writing
Severity: Minor
Found in AppPkg/Applications/Python/Python-2.7.2/Lib/StringIO.py - About 2 hrs to fix

    Function test has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    def test():
    import sys
    if sys.argv[1:]:
        file = sys.argv[1]
    else:
    Severity: Minor
    Found in AppPkg/Applications/Python/Python-2.7.2/Lib/StringIO.py - About 1 hr to fix

      Function write has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          def write(self, s):
        """Write a string to the file.

        There is no return value.
        """
      Severity: Minor
      Found in AppPkg/Applications/Python/Python-2.7.2/Lib/StringIO.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function test has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      def test():
    import sys
    if sys.argv[1:]:
        file = sys.argv[1]
    else:
      Severity: Minor
      Found in AppPkg/Applications/Python/Python-2.7.2/Lib/StringIO.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function readline has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def readline(self, length=None):
        r"""Read one entire line from the file.

        A trailing newline character is kept in the string (but may be absent
        when a file ends with an incomplete line). If the size argument is
      Severity: Minor
      Found in AppPkg/Applications/Python/Python-2.7.2/Lib/StringIO.py - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      Severity: Major
      Found in AppPkg/Applications/Python/Python-2.7.2/Lib/StringIO.py and 1 other location - About 2 wks to fix
      vector-uefi/fd/efi/StdLib/lib/python.27/StringIO.py on lines 0..324

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 1676.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status