Sign upLogin

hackedteam/vector-edk

View on GitHub
Star
AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/archive_util.py

Summary

Maintainability
F
1 wk
Test Coverage

Function make_zipfile has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

def make_zipfile(base_name, base_dir, verbose=0, dry_run=0):
    """Create a zip file from all the files under 'base_dir'.

    The output zip file will be named 'base_name' + ".zip".  Uses either the
    "zipfile" Python module (if available) or the InfoZIP "zip" utility
Severity: Minor
Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/archive_util.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function make_tarball has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

def make_tarball(base_name, base_dir, compress="gzip", verbose=0, dry_run=0,
                 owner=None, group=None):
    """Create a (possibly compressed) tar file from all the files under
    'base_dir'.
Severity: Minor
Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/archive_util.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function make_archive has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

def make_archive(base_name, format, root_dir=None, base_dir=None, verbose=0,
Severity: Major
Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/archive_util.py - About 1 hr to fix

    Function make_tarball has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def make_tarball(base_name, base_dir, compress="gzip", verbose=0, dry_run=0,
    Severity: Major
    Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/archive_util.py - About 50 mins to fix

      Function make_archive has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      def make_archive(base_name, format, root_dir=None, base_dir=None, verbose=0,
                 dry_run=0, owner=None, group=None):
    """Create an archive file (eg. zip or tar).

    'base_name' is the name of the file to create, minus any format-specific
      Severity: Minor
      Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/archive_util.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

                          if os.path.isfile(path):
                        zip.write(path, path)
                        log.info("adding '%s'" % path)
            zip.close()
      Severity: Major
      Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/archive_util.py - About 45 mins to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        Severity: Major
        Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/archive_util.py and 1 other location - About 1 wk to fix
        vector-uefi/fd/efi/StdLib/lib/python.27/distutils/archive_util.py on lines 0..243

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 1159.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status