hackedteam/vector-edk

View on GitHub
AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/bcppcompiler.py

Summary

Maintainability
F
3 wks
Test Coverage

Function link has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
Open

    def link (self,
              target_desc,
              objects,
              output_filename,
              output_dir=None,
Severity: Minor
Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/bcppcompiler.py - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function compile has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    def compile(self, sources,
                output_dir=None, macros=None, include_dirs=None, debug=0,
                extra_preargs=None, extra_postargs=None, depends=None):

        macros, objects, extra_postargs, pp_opts, build = \
Severity: Minor
Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/bcppcompiler.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function link has 13 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def link (self,

    Function object_filenames has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def object_filenames (self,
                              source_filenames,
                              strip_dir=0,
                              output_dir=''):
            if output_dir is None: output_dir = ''

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function compile has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def compile(self, sources,

      Function find_library_file has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def find_library_file (self, dirs, lib, debug=0):
              # List of effective library names to try, in order of preference:
              # xxx_bcpp.lib is better than xxx.lib
              # and xxx_d.lib is better than xxx.lib if debug is set
              #
      Severity: Minor
      Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/bcppcompiler.py - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function preprocess has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def preprocess (self,
                          source,
                          output_file=None,
                          macros=None,
                          include_dirs=None,
      Severity: Minor
      Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/bcppcompiler.py - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function preprocess has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def preprocess (self,
      Severity: Minor
      Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/bcppcompiler.py - About 45 mins to fix

        Function create_static_lib has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def create_static_lib (self,
        Severity: Minor
        Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/bcppcompiler.py - About 35 mins to fix

          Function create_static_lib has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def create_static_lib (self,
                                     objects,
                                     output_libname,
                                     output_dir=None,
                                     debug=0,
          Severity: Minor
          Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/bcppcompiler.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

          vector-uefi/fd/efi/StdLib/lib/python.27/distutils/bcppcompiler.py on lines 0..392

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 1870.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status