Sign upLogin

hackedteam/vector-edk

View on GitHub
Star
AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/cmd.py

Summary

Maintainability
F
2 wks
Test Coverage

Command has 30 functions (exceeds 20 allowed). Consider refactoring.
Open

class Command:
    """Abstract base class for defining command classes, the "worker bees"
    of the Distutils.  A useful analogy for command classes is to think of
    them as subroutines with local variables called "options".  The options
    are "declared" in 'initialize_options()' and "defined" (given their
Severity: Minor
Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/cmd.py - About 3 hrs to fix

    File cmd.py has 309 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    """distutils.cmd

Provides the Command class, the base class for the command classes
in the distutils.command package.
"""
    Severity: Minor
    Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/cmd.py - About 3 hrs to fix

      Function ensure_string_list has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          def ensure_string_list(self, option):
        """Ensure that 'option' is a list of strings.  If 'option' is
        currently a string, we split it either on /,\s*/ or /\s+/, so
        "foo bar baz", "foo,bar,baz", and "foo,   bar baz" all become
        ["foo", "bar", "baz"].
      Severity: Minor
      Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/cmd.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function make_file has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def make_file(self, infiles, outfile, func, args,
      Severity: Major
      Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/cmd.py - About 50 mins to fix

        Function make_archive has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def make_archive(self, base_name, format, root_dir=None, base_dir=None,
        Severity: Minor
        Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/cmd.py - About 45 mins to fix

          Function copy_file has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def copy_file(self, infile, outfile,
          Severity: Minor
          Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/cmd.py - About 45 mins to fix

            Function copy_tree has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def copy_tree(self, infile, outfile,
            Severity: Minor
            Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/cmd.py - About 45 mins to fix

              Function _ensure_tested_string has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def _ensure_tested_string(self, option, tester,
              Severity: Minor
              Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/cmd.py - About 35 mins to fix

                Function make_file has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    def make_file(self, infiles, outfile, func, args,
                  exec_msg=None, skip_msg=None, level=1):
        """Special case of 'execute()' for operations that process one or
        more input files and generate one output file.  Works just like
        'execute()', except the operation is skipped and a different
                Severity: Minor
                Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/cmd.py - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                Severity: Major
                Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/cmd.py and 1 other location - About 2 wks to fix
                vector-uefi/fd/efi/StdLib/lib/python.27/distutils/cmd.py on lines 0..457

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 1654.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status