Sign upLogin

hackedteam/vector-edk

View on GitHub
Star
AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/command/bdist_msi.py

Summary

Maintainability
F
1 mo
Test Coverage

File bdist_msi.py has 559 lines of code (exceeds 250 allowed). Consider refactoring.
Open

Severity: Major
Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/command/bdist_msi.py - About 1 day to fix

    Function add_files has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
    Open

    Severity: Minor
    Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/command/bdist_msi.py - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function add_ui has 147 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    Severity: Major
    Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/command/bdist_msi.py - About 5 hrs to fix

      Function finalize_options has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

      Severity: Minor
      Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/command/bdist_msi.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function run has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

      Severity: Minor
      Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/command/bdist_msi.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function run has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      Severity: Minor
      Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/command/bdist_msi.py - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

        Severity: Major
        Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/command/bdist_msi.py - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

          Severity: Major
          Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/command/bdist_msi.py - About 45 mins to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

            Severity: Major
            Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/command/bdist_msi.py and 1 other location - About 1 mo to fix
            vector-uefi/fd/efi/StdLib/lib/python.27/distutils/command/bdist_msi.py on lines 0..738

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 4875.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status