Sign upLogin

hackedteam/vector-edk

View on GitHub
Star
AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/msvc9compiler.py

Summary

Maintainability
F
1 mo
Test Coverage

File msvc9compiler.py has 572 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""distutils.msvc9compiler

Contains MSVCCompiler, an implementation of the abstract CCompiler class
for the Microsoft Visual Studio 2008.
Severity: Major
Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/msvc9compiler.py - About 1 day to fix

    Function link has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
    Open

        def link(self,
             target_desc,
             objects,
             output_filename,
             output_dir=None,
    Severity: Minor
    Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/msvc9compiler.py - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function compile has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

        def compile(self, sources,
                output_dir=None, macros=None, include_dirs=None, debug=0,
                extra_preargs=None, extra_postargs=None, depends=None):

        if not self.initialized:
    Severity: Minor
    Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/msvc9compiler.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function initialize has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        def initialize(self, plat_name=None):
        # multi-init means we would need to check platform same each time...
        assert not self.initialized, "don't init multiple times"
        if plat_name is None:
            plat_name = get_platform()
    Severity: Minor
    Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/msvc9compiler.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function find_vcvarsall has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    def find_vcvarsall(version):
    """Find the vcvarsall.bat file

    At first it tries to find the productdir of VS 2008 in the registry. If
    that fails it falls back to the VS90COMNTOOLS env var.
    Severity: Minor
    Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/msvc9compiler.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function link has 13 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def link(self,
    Severity: Major
    Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/msvc9compiler.py - About 1 hr to fix

      Function query_vcvarsall has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

      def query_vcvarsall(version, arch="x86"):
    """Launch vcvarsall.bat and read the settings from its environment
    """
    vcvarsall = find_vcvarsall(version)
    interesting = set(("include", "lib", "libpath", "path"))
      Severity: Minor
      Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/msvc9compiler.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function load_macros has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          def load_macros(self, version):
        self.set_macro("VCInstallDir", self.vsbase + r"\Setup\VC", "productdir")
        self.set_macro("VSInstallDir", self.vsbase + r"\Setup\VS", "productdir")
        self.set_macro("FrameworkDir", NET_BASE, "installroot")
        try:
      Severity: Minor
      Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/msvc9compiler.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function object_filenames has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          def object_filenames(self,
                         source_filenames,
                         strip_dir=0,
                         output_dir=''):
        # Copied from ccompiler.py, extended to return .res as 'object'-file
      Severity: Minor
      Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/msvc9compiler.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function compile has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def compile(self, sources,
      Severity: Major
      Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/msvc9compiler.py - About 1 hr to fix

        Function find_library_file has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            def find_library_file(self, dirs, lib, debug=0):
        # Prefer a debugging library if found (and requested), but deal
        # with it if we don't have one.
        if debug:
            try_names = [lib + "_d", lib]
        Severity: Minor
        Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/msvc9compiler.py - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function create_static_lib has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def create_static_lib(self,
        Severity: Minor
        Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/msvc9compiler.py - About 35 mins to fix

          Function create_static_lib has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              def create_static_lib(self,
                          objects,
                          output_libname,
                          output_dir=None,
                          debug=0,
          Severity: Minor
          Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/msvc9compiler.py - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function find_exe has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def find_exe(self, exe):
        """Return path to an MSVC executable program.

        Tries to find the program in several places: first, one of the
        MSVC program search paths from the registry; next, the directories
          Severity: Minor
          Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/msvc9compiler.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

          Severity: Major
          Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/msvc9compiler.py and 1 other location - About 1 mo to fix
          vector-uefi/fd/efi/StdLib/lib/python.27/distutils/msvc9compiler.py on lines 0..764

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 4422.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status