Sign upLogin

hackedteam/vector-edk

View on GitHub
Star
AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/unixccompiler.py

Summary

Maintainability
F
3 wks
Test Coverage

Function link has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

    def link(self, target_desc, objects,
             output_filename, output_dir=None, libraries=None,
             library_dirs=None, runtime_library_dirs=None,
             export_symbols=None, debug=0, extra_preargs=None,
             extra_postargs=None, build_temp=None, target_lang=None):
Severity: Minor
Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/unixccompiler.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _darwin_compiler_fixup has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

def _darwin_compiler_fixup(compiler_so, cc_args):
    """
    This function will strip '-isysroot PATH' and '-arch ARCH' from the
    compile flags if the user has specified one them in extra_compile_flags.
Severity: Minor
Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/unixccompiler.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function find_library_file has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    def find_library_file(self, dirs, lib, debug=0):
        shared_f = self.library_filename(lib, lib_type='shared')
        dylib_f = self.library_filename(lib, lib_type='dylib')
        static_f = self.library_filename(lib, lib_type='static')
Severity: Minor
Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/unixccompiler.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function link has 13 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def link(self, target_desc, objects,
Severity: Major
Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/unixccompiler.py - About 1 hr to fix

    Function preprocess has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def preprocess(self, source,
                   output_file=None, macros=None, include_dirs=None,
                   extra_preargs=None, extra_postargs=None):
        ignore, macros, include_dirs = \
            self._fix_compile_args(None, macros, include_dirs)
    Severity: Minor
    Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/unixccompiler.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function preprocess has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def preprocess(self, source,
    Severity: Minor
    Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/unixccompiler.py - About 45 mins to fix

      Function _compile has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def _compile(self, obj, src, ext, cc_args, extra_postargs, pp_opts):
      Severity: Minor
      Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/unixccompiler.py - About 45 mins to fix

        Function create_static_lib has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def create_static_lib(self, objects, output_libname,
        Severity: Minor
        Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/unixccompiler.py - About 35 mins to fix

          Function create_static_lib has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              def create_static_lib(self, objects, output_libname,
                          output_dir=None, debug=0, target_lang=None):
        objects, output_dir = self._fix_object_args(objects, output_dir)

        output_filename = \
          Severity: Minor
          Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/unixccompiler.py - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function runtime_library_dir_option has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              def runtime_library_dir_option(self, dir):
        # XXX Hackish, at the very least.  See Python bug #445902:
        # http://sourceforge.net/tracker/index.php
        #   ?func=detail&aid=445902&group_id=5470&atid=105470
        # Linkers on different platforms need different options to
          Severity: Minor
          Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/unixccompiler.py - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this function.
          Open

                      return "-R" + dir
          Severity: Major
          Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/unixccompiler.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return "-Wl,-R" + dir
            Severity: Major
            Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/unixccompiler.py - About 30 mins to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              Severity: Major
              Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/unixccompiler.py and 1 other location - About 2 wks to fix
              vector-uefi/fd/efi/StdLib/lib/python.27/distutils/unixccompiler.py on lines 0..346

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 1945.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status